You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:27:38 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #974: Enforce result check for data accessors batch get calls to prevent partial batch read.

jiajunwang commented on a change in pull request #974:
URL: https://github.com/apache/helix/pull/974#discussion_r420318485



##########
File path: helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java
##########
@@ -166,6 +167,7 @@
    * @param options Set the type of ZNode see the valid values in {@link AccessOption}
    * @return A list of children of the parent ZNode
    */
+  @Deprecated
   List<T> getChildren(String parentPath, List<Stat> stats, int options);
 
   /**

Review comment:
       Lei, let's address the interface design question in separate PR if necessary? This design is not changed here.
   
   In the current change, I am retrying once in the callers. But zero retry also works, I think, since we have added the async internal retry on connectivity issues. Do you think we shall just make it zero retry?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org