You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/07/24 03:01:02 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1749: [CELEBORN-827] Eliminate unnecessary chunksBeingTransferred calculation
pan3793 opened a new pull request, #1749:
URL: https://github.com/apache/incubator-celeborn/pull/1749
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Eliminate `chunksBeingTransferred` calculation when `celeborn.shuffle.io.maxChunksBeingTransferred` is not configured
### Why are the changes needed?
I observed high CPU usage on `ChunkStreamManager#chunksBeingTransferred` calculation. We can eliminate the method call if no threshold is configured, and investigate how to improve the method itself in the future.
<img width="1947" alt="image" src="https://github.com/apache/incubator-celeborn/assets/26535726/412c6a41-c0ce-440c-ae99-4424cb8702d3">
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI and Review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1749: [CELEBORN-827] Eliminate unnecessary chunksBeingTransferred calculation
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1749:
URL: https://github.com/apache/incubator-celeborn/pull/1749#issuecomment-1647367338
Thanks, merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1749: [CELEBORN-827] Eliminate unnecessary chunksBeingTransferred calculation
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1749:
URL: https://github.com/apache/incubator-celeborn/pull/1749#issuecomment-1647134041
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1749?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1749](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1749?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a4f1e41) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/8e849645eb3de0f6b889a14b45b618ad7a1de33c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8e84964) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 46.70% 46.72% +0.02%
==========================================
Files 161 161
Lines 10022 10021 -1
Branches 925 925
==========================================
+ Hits 4680 4681 +1
+ Misses 5022 5021 -1
+ Partials 320 319 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.27% <100.00%> (-<0.01%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1749/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1749: [CELEBORN-827] Eliminate unnecessary chunksBeingTransferred calculation
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1749: [CELEBORN-827] Eliminate unnecessary chunksBeingTransferred calculation
URL: https://github.com/apache/incubator-celeborn/pull/1749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1749: [CELEBORN-827] Eliminate unnecessary chunksBeingTransferred calculation
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1749:
URL: https://github.com/apache/incubator-celeborn/pull/1749#issuecomment-1647154998
cc @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1749: [CELEBORN-827] Eliminate unnecessary chunksBeingTransferred calculation
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1749:
URL: https://github.com/apache/incubator-celeborn/pull/1749#issuecomment-1648901735
This patch dramatically reduces the CPU usage

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org