You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/14 23:03:45 UTC

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9399: Add missing properties in CSV plugin

Jackie-Jiang commented on code in PR #9399:
URL: https://github.com/apache/pinot/pull/9399#discussion_r971368864


##########
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVMessageDecoder.java:
##########
@@ -49,6 +50,12 @@ public class CSVMessageDecoder implements StreamMessageDecoder<byte[]> {
   private static final String CONFIG_CSV_ESCAPE_CHARACTER = "escapeCharacter";
   private static final String CONFIG_CSV_MULTI_VALUE_DELIMITER = "multiValueDelimiter";
   public static final String NULL_STRING_VALUE = "nullStringValue";
+  public static final String SKIP_HEADER = "skipHeader";
+  public static final String IGNORE_EMPTY_LINES = "ignoreEmptyLines";
+  public static final String IGNORE_SURROUNDING_SPACE = "ignoreSurroundingSpace";

Review Comment:
   ```suggestion
     public static final String IGNORE_SURROUNDING_SPACES = "ignoreSurroundingSpaces";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org