You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/05/07 07:52:26 UTC
[GitHub] [drill] martin-g opened a new pull request #2218: DRILL-7911 Disable maven-surefire-plugin for Splunk
martin-g opened a new pull request #2218:
URL: https://github.com/apache/drill/pull/2218
# [DRILL-7911](https://issues.apache.org/jira/browse/DRILL-7911): Disable maven-surefire-plugin for Splunk
## Description
Disable running the unit tests for Contrib Storage Splunk for Linux ARM64 because there is no Docker image for splunk/splunk
## Documentation
No user visible changes. Only the unit tests are disabled for Contrib Storage Splunk module because there is no Docker image for `splunk/splunk` for Linux/arm64
## Testing
`mvn test` now passes for Contrib Storage Splunk module because the tests are skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] martin-g commented on pull request #2218: DRILL-7911 Disable maven-surefire-plugin for Splunk
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #2218:
URL: https://github.com/apache/drill/pull/2218#issuecomment-834736734
Correct!
With this change maven-surefire-plugin will be disabled on Linux/arm64.
But your question makes me think that it might be better to disable it by
default and enable it for x86_64. Because with this PR it will still fail
on Mac M1 or Linux s390x.
On Fri, May 7, 2021, 19:50 Charles S. Givre ***@***.***>
wrote:
> @martin-g <https://github.com/martin-g>
> Thanks for submitting. I just want to make sure that this PR only affects
> ARM builds of Drill. The tests will run on non ARM builds right?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/drill/pull/2218#issuecomment-834617109>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABYUQR53F7546U26EDUBP3TMQK7DANCNFSM44JHDO4A>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2218: DRILL-7911 Disable maven-surefire-plugin for Splunk
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2218:
URL: https://github.com/apache/drill/pull/2218#issuecomment-834617109
@martin-g
Thanks for submitting. I just want to make sure that this PR only affects ARM builds of Drill. The tests will run on non ARM builds right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre merged pull request #2218: DRILL-7911 Disable maven-surefire-plugin for Splunk for ARM Build
Posted by GitBox <gi...@apache.org>.
cgivre merged pull request #2218:
URL: https://github.com/apache/drill/pull/2218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2218: DRILL-7911 Disable maven-surefire-plugin for Splunk for ARM Build
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2218:
URL: https://github.com/apache/drill/pull/2218#issuecomment-838274001
@martin-g I approved this PR. Are we ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] martin-g commented on pull request #2218: DRILL-7911 Disable maven-surefire-plugin for Splunk
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #2218:
URL: https://github.com/apache/drill/pull/2218#issuecomment-835078781
@cgivre I've updated the PR to disable the maven-surefire-plugin for all CPU architectures but x86_64 (`amd64`, as reported by `System.getProperty("os.arch")`). I've tested it on Linux x86_64 and aarch64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] martin-g commented on pull request #2218: DRILL-7911 Disable maven-surefire-plugin for Splunk for ARM Build
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #2218:
URL: https://github.com/apache/drill/pull/2218#issuecomment-838283916
👍🏼
I have no planned changes here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] martin-g commented on pull request #2218: DRILL-7911 Disable maven-surefire-plugin for Splunk
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #2218:
URL: https://github.com/apache/drill/pull/2218#issuecomment-834395867
With this PR I just disable maven-surefire-plugin for Splunk module on Linux ARM64.
https://github.com/apache/hbase/blob/6cfff27465620112eb308cf881e6321d928743ed/pom.xml#L3848-L3859 just exports a system property that is used to load a custom build of Protobuf-Java **2.x**. The official Protobuf-Java 2.x does not support aarch64. Protobuf started providing aarch64 binaries in 3.x. HBase still uses Protobuf 2.x and thus this custom build is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org