[GitHub] [helix] jiajunwang commented on a change in pull request #1292: Remove closed ZKConnectionManager from connection manager pool

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1292:
URL: https://github.com/apache/helix/pull/1292#discussion_r473364596



##########
File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/SharedZkClientFactory.java
##########
@@ -117,6 +117,7 @@ private ZkConnectionManager getOrCreateZkConnectionManager(
   private void cleanupConnectionManager(ZkConnectionManager zkConnectionManager) {
     synchronized (_connectionManagerPool) {
       zkConnectionManager.close(true);

Review comment:
       When skipIfWatched == true, the close() call may not actually disconnect the zkConnectionManager given shared watchers exist. So we shall not remove the zkConnectionManager from the pool without a proper check.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org