You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/27 18:17:44 UTC
[GitHub] codecov-io commented on issue #5296: [dashboard v2] add
`` component
codecov-io commented on issue #5296: [dashboard v2] add `<MissingChart />` component
URL: https://github.com/apache/incubator-superset/pull/5296#issuecomment-400780698
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5296?src=pr&el=h1) Report
> Merging [#5296](https://codecov.io/gh/apache/incubator-superset/pull/5296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4ee984c6ded4b6e56566ae51683242bc2946c2a3?src=pr&el=desc) will **increase** coverage by `0.7%`.
> The diff coverage is `86.66%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5296/graphs/tree.svg?token=KsB0fHcx6l&width=650&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5296?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5296 +/- ##
========================================
+ Coverage 61.29% 62% +0.7%
========================================
Files 368 369 +1
Lines 23457 23981 +524
Branches 2716 2717 +1
========================================
+ Hits 14379 14870 +491
- Misses 9066 9099 +33
Partials 12 12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5296?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set/assets/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/5296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvYWN0aW9ucy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `41.98% <0%> (-0.66%)` | :arrow_down: |
| [...erset/assets/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9RdWVyeVNlYXJjaC5qc3g=) | `68.18% <100%> (ø)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9DaGFydC5qc3g=) | `83.13% <100%> (+0.41%)` | :arrow_up: |
| [...t/assets/src/dashboard/components/MissingChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9NaXNzaW5nQ2hhcnQuanN4) | `100% <100%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5296/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `84.55% <0%> (+3.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5296?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5296?src=pr&el=footer). Last update [4ee984c...a7a6d1c](https://codecov.io/gh/apache/incubator-superset/pull/5296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org