[GitHub] [storm] Ethanlm commented on pull request #3307: STORM-3673 convert Builtin metrics to use V2 API

[GitBox <gi...@apache.org>]

Ethanlm commented on pull request #3307:
URL: https://github.com/apache/storm/pull/3307#issuecomment-670723780


   > I'm not sure what backwards compatibility concern you're worried about.
   
   Sorry for not being clear. What I meant is with this change, the metrics are changed from
   
   for example
   
   ```
   __acked-count: {stream1: 2, stream2: 3}
   ```
   to
   ```
   __acker-count-upstreamComp:stream1.m1_rate, 
   __acker-count-upstreamComp:stream1.m5_rate
   ...
   ```
   
   I guess it is acceptable since it is only the metrics. Otherwise we need to record the same metrics for V1 and V2 format in the same time, which adds a lot of overhead.  At least the Java api is preserved for older topologies. 
   
   But we need to update  https://github.com/apache/storm/blob/master/docs/Metrics.md#tuple-counting-metrics to reflect the format change.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org