You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "JorringHsiao (via GitHub)" <gi...@apache.org> on 2024/03/13 09:08:16 UTC
[I] [Feature][javaagent][es-plugin] Optimize the handling of the `xxxAsync` method span [skywalking]
JorringHsiao opened a new issue, #12010:
URL: https://github.com/apache/skywalking/issues/12010
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Currently, both synchronous method (ex. **org.elasticsearch.client.RestHighLevelClient#`search`**) and asynchronous method (ex. **org.elasticsearch.client.RestHighLevelClient#`searchAsync`**) complete the span after the method call completes.
This is normal for synchronous methods, *however for asynchronous methods, the elapsed time in its span is incorrect*.
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a pull request to implement this on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature][javaagent][es-plugin] Optimize the handling of the `xxxAsync` method span [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #12010:
URL: https://github.com/apache/skywalking/issues/12010#issuecomment-1993879445
If you want to enhance that, you could mark span as async mode, and close in the callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature][javaagent][es-plugin] Optimize the handling of the `xxxAsync` method span [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #12010: [Feature][javaagent][es-plugin] Optimize the handling of the `xxxAsync` method span
URL: https://github.com/apache/skywalking/issues/12010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature][javaagent][es-plugin] Optimize the handling of the `xxxAsync` method span [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #12010:
URL: https://github.com/apache/skywalking/issues/12010#issuecomment-1993884383
As usual, this is not covered by maintainers. Feel free to contribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org