You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/26 16:38:15 UTC
[GitHub] [arrow] Dandandan opened a new pull request #9018: ARROW-11039: [Rust] Performance improvement for utf-8 to float
Dandandan opened a new pull request #9018:
URL: https://github.com/apache/arrow/pull/9018
Utilize `lexical_core::parse` for faster parsing.
```
cast utf8 to f32 time: [25.840 us 25.878 us 25.921 us]
change: [-45.735% -45.590% -45.408%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
3 (3.00%) high mild
3 (3.00%) high severe
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9018: ARROW-11039: [Rust] Performance improvement for utf-8 to float cast
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9018:
URL: https://github.com/apache/arrow/pull/9018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9018: ARROW-11039: [Rust] Performance improvement for utf-8 to float
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9018:
URL: https://github.com/apache/arrow/pull/9018#issuecomment-751377872
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=h1) Report
> Merging [#9018](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=desc) (754bba5) into [master](https://codecov.io/gh/apache/arrow/commit/a4f7c4a2acda874b3d6eb2eb4c986e7c3267c755?el=desc) (a4f7c4a) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9018 +/- ##
==========================================
- Coverage 82.87% 82.87% -0.01%
==========================================
Files 201 201
Lines 49739 49737 -2
==========================================
- Hits 41220 41218 -2
Misses 8519 8519
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow/pull/9018/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Nhc3QucnM=) | `96.83% <100.00%> (-0.01%)` | :arrow_down: |
| [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9018/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9018/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=footer). Last update [a4f7c4a...754bba5](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9018: ARROW-11039: [Rust] Performance improvement for utf-8 to float
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9018:
URL: https://github.com/apache/arrow/pull/9018#issuecomment-751377872
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=h1) Report
> Merging [#9018](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=desc) (ff820d6) into [master](https://codecov.io/gh/apache/arrow/commit/a4f7c4a2acda874b3d6eb2eb4c986e7c3267c755?el=desc) (a4f7c4a) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9018 +/- ##
==========================================
- Coverage 82.87% 82.86% -0.01%
==========================================
Files 201 201
Lines 49739 49737 -2
==========================================
- Hits 41220 41217 -3
- Misses 8519 8520 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow/pull/9018/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Nhc3QucnM=) | `96.83% <100.00%> (-0.01%)` | :arrow_down: |
| [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9018/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=footer). Last update [a4f7c4a...ff820d6](https://codecov.io/gh/apache/arrow/pull/9018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9018: ARROW-11039: [Rust] Performance improvement for utf-8 to float
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9018:
URL: https://github.com/apache/arrow/pull/9018#issuecomment-751373632
https://issues.apache.org/jira/browse/ARROW-11039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org