You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/13 07:21:23 UTC
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull
request #1231: [SCB-1304]FallbackPolicy#getFallbackResponse add Throwable
liubao68 commented on a change in pull request #1231: [SCB-1304]FallbackPolicy#getFallbackResponse add Throwable
URL: https://github.com/apache/servicecomb-java-chassis/pull/1231#discussion_r293236653
##########
File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/FallbackPolicy.java
##########
@@ -22,7 +22,7 @@
public interface FallbackPolicy {
String name();
- Response getFallbackResponse(Invocation invocation);
+ Response getFallbackResponse(Invocation invocation, Throwable error);
Review comment:
I think the change is fine. Users can change their implementations easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services