You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/09/21 23:40:53 UTC
Review Request: Fix for webui table sorting re-sizing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7215/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This adds an invisible character after unsorted table headers, so that sizing remains consistent.
Diffs
-----
src/webui/master/static/controllers.js b5f6e7470bb0207276a9ad72fa56e426868f9b19
src/webui/master/static/mesos.css f4bc51baf419015543b105be3125061b43de7368
Diff: https://reviews.apache.org/r/7215/diff/
Testing
-------
mesos-local.sh
Thanks,
Ben Mahler
Re: Review Request: Fix for webui table sorting re-sizing.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7215/#review11803
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 21, 2012, 9:40 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7215/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2012, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This adds an invisible character after unsorted table headers, so that sizing remains consistent.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js b5f6e7470bb0207276a9ad72fa56e426868f9b19
> src/webui/master/static/mesos.css f4bc51baf419015543b105be3125061b43de7368
>
> Diff: https://reviews.apache.org/r/7215/diff/
>
>
> Testing
> -------
>
> mesos-local.sh
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fix for webui table sorting re-sizing.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7215/#review12251
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Sept. 21, 2012, 9:40 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7215/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2012, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This adds an invisible character after unsorted table headers, so that sizing remains consistent.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js b5f6e7470bb0207276a9ad72fa56e426868f9b19
> src/webui/master/static/mesos.css f4bc51baf419015543b105be3125061b43de7368
>
> Diff: https://reviews.apache.org/r/7215/diff/
>
>
> Testing
> -------
>
> mesos-local.sh
>
>
> Thanks,
>
> Ben Mahler
>
>