[GitHub] [unomi] Taybou commented on a change in pull request #150: UNOMI-330 Events non-persistant by default

[GitBox <gi...@apache.org>]

Taybou commented on a change in pull request #150:
URL: https://github.com/apache/unomi/pull/150#discussion_r416746866



##########
File path: api/src/main/java/org/apache/unomi/api/Event.java
##########
@@ -100,7 +100,7 @@ public Event(String itemId, String eventType, Session session, Profile profile,
      * @param timestamp the timestamp associated with the event if provided
      */
     public Event(String eventType, Session session, Profile profile, String scope, Item source, Item target, Date timestamp) {
-        this(eventType, session, profile, scope, source, target, null, timestamp, false);
+        this(eventType, session, profile, scope, source, target, null, timestamp, true);

Review comment:
       It's quite confusing but true for persistent and the comment says non-persistent!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org