[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15339: [Feature](aggregate-function) support funtion group_uniq_array

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15339:
URL: https://github.com/apache/doris/pull/15339#discussion_r1063508277


##########
be/test/vec/aggregate_functions/agg_group_array_test.cpp:
##########
@@ -0,0 +1,122 @@
+#include <gtest/gtest.h>
+
+#include "gtest/gtest.h"
+#include "vec/aggregate_functions/aggregate_function_simple_factory.h"
+#include "vec/common/arena.h"
+#include "vec/core/field.h"
+#include "vec/data_types/data_type.h"
+#include "vec/data_types/data_type_date.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/data_types/data_type_string.h"
+#include "vec/data_types/data_type_date_time.h"
+
+namespace doris::vectorized {
+
+void register_aggregate_function_group_uniq_array(AggregateFunctionSimpleFactory& factory);
+
+class VAggGroupArrayTest : public testing::Test {
+private:
+    Arena _agg_arena_pool;
+
+public:
+    void SetUp() override {
+        AggregateFunctionSimpleFactory factory = AggregateFunctionSimpleFactory::instance();
+        register_aggregate_function_group_uniq_array(factory);
+    }
+
+    void TearDown() override {}
+
+    template <typename DataType>
+    void agg_group_uniq_array_add_elements(AggregateFunctionPtr agg_function,
+                                           AggregateDataPtr place, size_t input_nums) {
+        using FieldType = typename DataType::FieldType;
+        auto type = std::make_shared<DataType>();
+        auto input_col = type->create_column();
+        for (size_t i = 0; i < input_nums; ++i) {
+            if constexpr (std::is_same_v<DataType, DataTypeString>) {
+                auto item = std::string("item") + std::to_string(i);
+                input_col->insert_data(item.c_str(), item.size());
+            } else {
+                auto item = FieldType(static_cast<uint64_t>(i));
+                input_col->insert_data(reinterpret_cast<const char*>(&item), 0);
+            }
+        }
+        EXPECT_EQ(input_col->size(), input_nums);
+
+        const IColumn* column[1] = {input_col.get()};
+        for (int i = 0; i < input_col->size(); i++) {
+            agg_function->add(place, column, i, &_agg_arena_pool);
+        }
+    }
+
+    template<typename DataType>
+    void test_agg_group_uniq_array(size_t input_nums = 0){
+        DataTypes data_types = {(DataTypePtr)std::make_shared<DataType>()};
+        LOG(INFO) << "test_agg_group_uniq_array for type"
+                  << "(" << data_types[0]->get_name() << ")";
+
+        Array array;
+        AggregateFunctionSimpleFactory factory = AggregateFunctionSimpleFactory::instance();
+        auto agg_function = factory.get("group_uniq_array", data_types, array);
+        EXPECT_NE(agg_function, nullptr);
+
+        std::unique_ptr<char[]> memory(new char[agg_function->size_of_data()]);
+        AggregateDataPtr place = memory.get();
+        agg_function->create(place);
+
+        agg_group_uniq_array_add_elements<DataType>(agg_function, place, input_nums);
+        
+        ColumnString buf;

Review Comment:
   warning: calling a private constructor of class 'doris::vectorized::ColumnString' [clang-diagnostic-error]
   ```cpp
           ColumnString buf;
                        ^
   ```
   **be/src/vec/columns/column_string.h:75:** declared private here
   ```cpp
       ColumnString() = default;
       ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org