[GitHub] [incubator-nuttx-apps] pussuw commented on a diff in pull request #1147: nshlib/nsh_fileapps.c: Pass global environ instead of NULL for posix_spawnp

[GitBox <gi...@apache.org>]

pussuw commented on code in PR #1147:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1147#discussion_r855012170


##########
nshlib/nsh_fileapps.c:
##########
@@ -126,7 +127,7 @@ int nsh_fileapp(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd,
    * failure.
    */
 
-  ret = posix_spawnp(&pid, cmd, &file_actions, &attr, argv, NULL);
+  ret = posix_spawnp(&pid, cmd, &file_actions, &attr, argv, environ);

Review Comment:
   The header file is already updated in:
   https://github.com/apache/incubator-nuttx/pull/6010
   
   Need to get it in first and this error will disappear



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org