You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by bo...@apache.org on 2012/03/18 18:46:32 UTC
svn commit: r1302181 -
/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
Author: bodewig
Date: Sun Mar 18 17:46:32 2012
New Revision: 1302181
URL: http://svn.apache.org/viewvc?rev=1302181&view=rev
Log:
duplicate two lines of TarArchiveEntry constructor code rather than hiding an important exception
Modified:
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java?rev=1302181&r1=1302180&r2=1302181&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java Sun Mar 18 17:46:32 2012
@@ -309,7 +309,8 @@ public class TarArchiveEntry implements
* @throws IllegalArgumentException if any of the numeric fields have an invalid format
*/
public TarArchiveEntry(byte[] headerBuf) {
- this(headerBuf, null);
+ this();
+ parseTarHeader(headerBuf);
}
/**
@@ -321,18 +322,10 @@ public class TarArchiveEntry implements
* @since Commons Compress 1.4
* @throws IllegalArgumentException if any of the numeric fields have an invalid format
*/
- public TarArchiveEntry(byte[] headerBuf, ZipEncoding encoding) {
+ public TarArchiveEntry(byte[] headerBuf, ZipEncoding encoding)
+ throws IOException {
this();
- try {
- parseTarHeader(headerBuf, encoding);
- } catch (IOException ex) {
- try {
- parseTarHeader(headerBuf, encoding, true);
- } catch (IOException ex2) {
- // impossible
- throw new RuntimeException(ex2);
- }
- }
+ parseTarHeader(headerBuf, encoding);
}
/**