[GitHub] [iceberg] moriyoshi commented on a diff in pull request #8144: Python: allow projection of Iceberg fields to pyarrow table schema with names

["moriyoshi (via GitHub)" <gi...@apache.org>]

moriyoshi commented on code in PR #8144:
URL: https://github.com/apache/iceberg/pull/8144#discussion_r1308181465


##########
python/tests/io/test_pyarrow.py:
##########
@@ -360,6 +361,65 @@ def test_schema_to_pyarrow_schema(table_schema_nested: Schema) -> None:
     assert repr(actual) == expected
 
 
+def test_pyarrow_to_schema(table_schema_simple: Schema, table_schema_nested: Schema) -> None:

Review Comment:
   Yes, now that `test_pyarrow.py` contains some backend specific tests, it makes more sense to move those visitor related tests to another file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org