You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/28 17:23:02 UTC

[GitHub] [arrow] ghuls commented on a change in pull request #9349: ARROW-10056: [C++][Python] PyArrow fails to read (valid) Feather v2 f…

ghuls commented on a change in pull request #9349:
URL: https://github.com/apache/arrow/pull/9349#discussion_r566271219



##########
File path: cpp/src/arrow/ipc/reader.cc
##########
@@ -58,6 +58,8 @@
 #include "generated/Schema_generated.h"
 #include "generated/SparseTensor_generated.h"
 
+#define FLATBUFFER_MAX_TABLES 10000000

Review comment:
       > According to various sources on the Internet it should be ok to just pass `UINT_MAX`. @wesm @emkornfield What do you think?
   
   That should be fine indeed. I got the solution for this problem from:
   https://groups.google.com/g/flatbuffers/c/JtDGnBPx9is
   
   > You simply need to pass your own max_tables to the FlatBufferBuilder constructor.
   > Pass e.g. INT_MAX and you will guaranteed never hit it :)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org