You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/23 02:40:57 UTC
[GitHub] [rocketmq] hzh0425 opened a new pull request, #4672: [Summer of code] Identify broker by uuid
hzh0425 opened a new pull request, #4672:
URL: https://github.com/apache/rocketmq/pull/4672
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Identify broker by uuid
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #4672: [Summer of code] Identify broker by uuid
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #4672:
URL: https://github.com/apache/rocketmq/pull/4672#issuecomment-1210122845
@hzh0425 I have created a temporary [feature/controler-broker-identify](https://github.com/apache/rocketmq/tree/feature/controler-broker-identify) branch to solve this issue. You can solve the code conflict first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4672: [Summer of code] Identify broker by uuid
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4672:
URL: https://github.com/apache/rocketmq/pull/4672#issuecomment-1212670169
Obviously, this pull request is sort of haste. The problem trying to solve is not new and there are better ones in the field. A numeric "node-id" suffices as long as we have a clear cluster membership algorithm in hand.
Thinking it out prior to code is always good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on pull request #4672: [Summer of code] Identify broker by uuid
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #4672:
URL: https://github.com/apache/rocketmq/pull/4672#issuecomment-1193043308
@RongtongJin Hi, I open it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4672: [Summer of code] Identify broker by uuid
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4672:
URL: https://github.com/apache/rocketmq/pull/4672#issuecomment-1211554735
Two questions:
1. Why uuid?
2. We already have brokerId, adding a second property named brokerIdentity is very confusing. Give it another name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 closed pull request #4672: [Summer of code] Identify broker by uuid
Posted by GitBox <gi...@apache.org>.
hzh0425 closed pull request #4672: [Summer of code] Identify broker by uuid
URL: https://github.com/apache/rocketmq/pull/4672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] dongeforever commented on pull request #4672: [Summer of code] Identify broker by uuid
Posted by GitBox <gi...@apache.org>.
dongeforever commented on PR #4672:
URL: https://github.com/apache/rocketmq/pull/4672#issuecomment-1211766291
@RongtongJin how about naming it as "controllerBrokerId", means it is an id for controller mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #4672: [Summer of code] Identify broker by uuid
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #4672:
URL: https://github.com/apache/rocketmq/pull/4672#issuecomment-1212660949
> 2\. property
Hi @dongeforever , There is already a property similar to controllerBrokerId in org.apache.rocketmq.controller.impl.manager.BrokerInfo#brokerIdTable
The controllerBrokerId is currently allocated according to the IP. If the IP changes, there will be problems. So we hope to have a uuid property that can identify the broker and does not require user configuration. It will also be initialized (if not) when the broker starts and be persisted to the store directory. After that, the identity of the broker will be changed from IP to persistent uuid.
However, after your reminder, we have come up with another solution. If we persist the controllerBrokerId allocated by the controller according to the IP to the local storage of the broker when the first apply, and bring the controllerBrokerId with each request later, it seems that we can also solve the issue of IP change. For the current implementation, such changes will be slightly larger.
Currently, we prefer the second solution. What about you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org