You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2016/02/02 08:09:51 UTC
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/11019
[SPARK-13135][SQL] Don't print expressions recursively in generated code
Our code generation currently prints expressions recursively. For example, for expression "(1 + 1) + 1)", we would print the following:
"(1 + 1) + 1)"
"(1 + 1)"
"1"
"1"
This pull request changes codegen to print this only once.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark SPARK-13135
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11019.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11019
----
commit 2c2b0079d4397cb59a72a8f4631d6870b54ff0c4
Author: Reynold Xin <rx...@databricks.com>
Date: 2016-02-02T07:06:46Z
[SPARK-13135][SQL] Don't print expressions recursively in generated code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178426117
**[Test build #50551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50551/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178416006
query:
```scala
sqlContext.range(1, 1000).select('id + 1 + 1).show()
```
old generated code:
```java
/* 068 */ while (!Range_overflow3 && Range_number2 < Range_partitionEnd1) {
/* 069 */ long Range_value4 = Range_number2;
/* 070 */ Range_number2 += 1L;
/* 071 */ if (Range_number2 < Range_value4 ^ 1L < 0) {
/* 072 */ Range_overflow3 = true;
/* 073 */ }
/* 074 */
/* 075 */ /* ((input[0, bigint] + 1) + 1) */
/* 076 */ /* (input[0, bigint] + 1) */
/* 077 */ /* input[0, bigint] */
/* 078 */
/* 079 */ /* 1 */
/* 080 */
/* 081 */ long Project_value8 = -1L;
/* 082 */ Project_value8 = Range_value4 + 1L;
/* 083 */ /* 1 */
/* 084 */
/* 085 */ long Project_value6 = -1L;
/* 086 */ Project_value6 = Project_value8 + 1L;
/* 087 */
/* 088 */
/* 089 */ /* input[0, bigint] */
/* 090 */
/* 091 */ Project_rowWriter19.write(0, Project_value6);
/* 092 */ currentRow = Project_result17;
/* 093 */ return;
/* 094 */
/* 095 */
/* 096 */ }
```
new generated code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178872055
**[Test build #2494 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2494/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by rxin <gi...@git.apache.org>.
Github user rxin closed the pull request at:
https://github.com/apache/spark/pull/11019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178426158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50551/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11019#discussion_r51647306
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala ---
@@ -125,6 +125,7 @@ object GenerateMutableProjection extends CodeGenerator[Seq[Expression], () => Mu
public java.lang.Object apply(java.lang.Object _i) {
InternalRow ${ctx.INPUT_ROW} = (InternalRow) _i;
+ // project list: ${expressions.map(_.toCommentSafeString).mkString(", ")}
--- End diff --
we should use `/* ...... */` in case the comments cross multiple lines
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178895272
**[Test build #2494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2494/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178708459
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178810783
**[Test build #2492 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2492/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178426154
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178459661
**[Test build #50554 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50554/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178460319
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by nongli <gi...@git.apache.org>.
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178830486
I like this output much better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178848022
**[Test build #2492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2492/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178415439
New generated code:
```java
scala> sqlContext.range(1, 1000).agg(expr("count(1)"), expr("sum(id)")).show()
/* 001 */
/* 002 */ public Object generate(Object[] references) {
/* 003 */ return new GeneratedIterator(references);
/* 004 */ }
/* 005 */
/* 006 */ class GeneratedIterator extends org.apache.spark.sql.execution.BufferedRowIterator {
/* 007 */
/* 008 */ private Object[] references;
/* 009 */ private boolean TungstenAggregate_initAgg0;
/* 010 */ private boolean TungstenAggregate_bufIsNull1;
/* 011 */ private long TungstenAggregate_bufValue2;
/* 012 */ private boolean TungstenAggregate_bufIsNull5;
/* 013 */ private long TungstenAggregate_bufValue6;
/* 014 */ private boolean Range_initRange10;
/* 015 */ private long Range_partitionEnd11;
/* 016 */ private long Range_number12;
/* 017 */ private boolean Range_overflow13;
/* 018 */ private UnsafeRow TungstenAggregate_result39;
/* 019 */ private org.apache.spark.sql.catalyst.expressions.codegen.BufferHolder TungstenAggregate_holder40;
/* 020 */ private org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter TungstenAggregate_rowWriter41;
/* 021 */
/* 022 */ private void TungstenAggregate_doAggregateWithoutKey9() throws java.io.IOException {
/* 023 */ // initialize agg buffer:
/* 024 */ // [(count(1),mode=Partial,isDistinct=false), (sum(id#18L),mode=Partial,isDistinct=false)]
/* 025 */
/* 026 */ TungstenAggregate_bufIsNull1 = false;
/* 027 */ TungstenAggregate_bufValue2 = 0L;
/* 028 */
/* 029 */ final long TungstenAggregate_value8 = -1L;
/* 030 */ TungstenAggregate_bufIsNull5 = true;
/* 031 */ TungstenAggregate_bufValue6 = TungstenAggregate_value8;
/* 032 */
/* 033 */
/* 034 */
/* 035 */ // initialize Range
/* 036 */ if (!Range_initRange10) {
/* 037 */ Range_initRange10 = true;
/* 038 */ if (input.hasNext()) {
/* 039 */ initRange(((InternalRow) input.next()).getInt(0));
/* 040 */ } else {
/* 041 */ return;
/* 042 */ }
/* 043 */ }
/* 044 */
/* 045 */ while (!Range_overflow13 && Range_number12 < Range_partitionEnd11) {
/* 046 */ long Range_value14 = Range_number12;
/* 047 */ Range_number12 += 1L;
/* 048 */ if (Range_number12 < Range_value14 ^ 1L < 0) {
/* 049 */ Range_overflow13 = true;
/* 050 */ }
/* 051 */
/* 052 */ // aggregate: [(count#23L + 1), (coalesce(sum#24L,cast(0 as bigint)) + cast(id#18L as bigint))]
/* 053 */
/* 054 */
/* 055 */
/* 056 */ long TungstenAggregate_value16 = -1L;
/* 057 */ TungstenAggregate_value16 = TungstenAggregate_bufValue2 + 1L;
/* 058 */
/* 059 */
/* 060 */
/* 061 */
/* 062 */ boolean TungstenAggregate_isNull23 = TungstenAggregate_bufIsNull5;
/* 063 */ long TungstenAggregate_value24 = TungstenAggregate_bufValue6;
/* 064 */
/* 065 */ if (TungstenAggregate_isNull23) {
/* 066 */
/* 067 */ boolean TungstenAggregate_isNull27 = false;
/* 068 */ long TungstenAggregate_value28 = -1L;
/* 069 */ if (!false) {
/* 070 */ TungstenAggregate_value28 = (long) 0;
/* 071 */ }
/* 072 */
/* 073 */ if (!TungstenAggregate_isNull27) {
/* 074 */ TungstenAggregate_isNull23 = false;
/* 075 */ TungstenAggregate_value24 = TungstenAggregate_value28;
/* 076 */ }
/* 077 */ }
/* 078 */
/* 079 */
/* 080 */ boolean TungstenAggregate_isNull31 = false;
/* 081 */ long TungstenAggregate_value32 = -1L;
/* 082 */ if (!false) {
/* 083 */ TungstenAggregate_value32 = Range_value14;
/* 084 */ }
/* 085 */
/* 086 */ long TungstenAggregate_value22 = -1L;
/* 087 */ TungstenAggregate_value22 = TungstenAggregate_value24 + TungstenAggregate_value32;
/* 088 */
/* 089 */ // update agg buffer
/* 090 */
/* 091 */ TungstenAggregate_bufIsNull1 = false;
/* 092 */ TungstenAggregate_bufValue2 = TungstenAggregate_value16;
/* 093 */
/* 094 */ TungstenAggregate_bufIsNull5 = false;
/* 095 */ TungstenAggregate_bufValue6 = TungstenAggregate_value22;
/* 096 */
/* 097 */
/* 098 */ }
/* 099 */
/* 100 */ }
/* 101 */
/* 102 */
/* 103 */ private void initRange(int idx) {
/* 104 */ java.math.BigInteger index = java.math.BigInteger.valueOf(idx);
/* 105 */ java.math.BigInteger numSlice = java.math.BigInteger.valueOf(1L);
/* 106 */ java.math.BigInteger numElement = java.math.BigInteger.valueOf(999L);
/* 107 */ java.math.BigInteger step = java.math.BigInteger.valueOf(1L);
/* 108 */ java.math.BigInteger start = java.math.BigInteger.valueOf(1L);
/* 109 */
/* 110 */ java.math.BigInteger st = index.multiply(numElement).divide(numSlice).multiply(step).add(start);
/* 111 */ if (st.compareTo(java.math.BigInteger.valueOf(Long.MAX_VALUE)) > 0) {
/* 112 */ Range_number12 = Long.MAX_VALUE;
/* 113 */ } else if (st.compareTo(java.math.BigInteger.valueOf(Long.MIN_VALUE)) < 0) {
/* 114 */ Range_number12 = Long.MIN_VALUE;
/* 115 */ } else {
/* 116 */ Range_number12 = st.longValue();
/* 117 */ }
/* 118 */
/* 119 */ java.math.BigInteger end = index.add(java.math.BigInteger.ONE).multiply(numElement).divide(numSlice)
/* 120 */ .multiply(step).add(start);
/* 121 */ if (end.compareTo(java.math.BigInteger.valueOf(Long.MAX_VALUE)) > 0) {
/* 122 */ Range_partitionEnd11 = Long.MAX_VALUE;
/* 123 */ } else if (end.compareTo(java.math.BigInteger.valueOf(Long.MIN_VALUE)) < 0) {
/* 124 */ Range_partitionEnd11 = Long.MIN_VALUE;
/* 125 */ } else {
/* 126 */ Range_partitionEnd11 = end.longValue();
/* 127 */ }
/* 128 */ }
/* 129 */
/* 130 */
/* 131 */ public GeneratedIterator(Object[] references) {
/* 132 */ this.references = references;
/* 133 */ TungstenAggregate_initAgg0 = false;
/* 134 */
/* 135 */
/* 136 */
/* 137 */
/* 138 */ Range_initRange10 = false;
/* 139 */ Range_partitionEnd11 = 0L;
/* 140 */ Range_number12 = 0L;
/* 141 */ Range_overflow13 = false;
/* 142 */ TungstenAggregate_result39 = new UnsafeRow(2);
/* 143 */ this.TungstenAggregate_holder40 = new org.apache.spark.sql.catalyst.expressions.codegen.BufferHolder(TungstenAggregate_result39, 0);
/* 144 */ this.TungstenAggregate_rowWriter41 = new org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter(TungstenAggregate_holder40, 2);
/* 145 */ }
/* 146 */
/* 147 */ protected void processNext() throws java.io.IOException {
/* 148 */
/* 149 */ if (!TungstenAggregate_initAgg0) {
/* 150 */ TungstenAggregate_initAgg0 = true;
/* 151 */ TungstenAggregate_doAggregateWithoutKey9();
/* 152 */
/* 153 */ // output the result
/* 154 */
/* 155 */
/* 156 */
/* 157 */ // project list: [input[0, bigint], input[1, bigint]]
/* 158 */
/* 159 */
/* 160 */ TungstenAggregate_rowWriter41.zeroOutNullBytes();
/* 161 */
/* 162 */
/* 163 */ if (TungstenAggregate_bufIsNull1) {
/* 164 */ TungstenAggregate_rowWriter41.setNullAt(0);
/* 165 */ } else {
/* 166 */ TungstenAggregate_rowWriter41.write(0, TungstenAggregate_bufValue2);
/* 167 */ }
/* 168 */
/* 169 */
/* 170 */ if (TungstenAggregate_bufIsNull5) {
/* 171 */ TungstenAggregate_rowWriter41.setNullAt(1);
/* 172 */ } else {
/* 173 */ TungstenAggregate_rowWriter41.write(1, TungstenAggregate_bufValue6);
/* 174 */ }
/* 175 */ currentRow = TungstenAggregate_result39;
/* 176 */ return;
/* 177 */
/* 178 */ }
/* 179 */
/* 180 */ }
/* 181 */ }
/* 182 */
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178416188
Let me know if you guys think this is more clear. Alternatively, we can also print the expression comment only for top level expressions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178765827
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50570/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178460324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50554/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178428206
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11019#discussion_r51534316
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
@@ -36,11 +36,11 @@ import org.apache.spark.util.Utils
/**
* Java source for evaluating an [[Expression]] given a [[InternalRow]] of input.
*
- * @param code The sequence of statements required to evaluate the expression.
- * @param isNull A term that holds a boolean value representing whether the expression evaluated
- * to null.
- * @param value A term for a (possibly primitive) value of the result of the evaluation. Not
- * valid if `isNull` is set to `true`.
+ * @param code The Java source code required to evaluate the expression.
+ * @param isNull Name of the variable that holds the boolean value representing whether the
+ * expression evaluated to null.
+ * @param value Name of the variable that holds the (possibly primitive) value of the result
--- End diff --
note that `value` could be a constant too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178417590
**[Test build #50551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50551/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178722621
**[Test build #50570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50570/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178428368
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178765458
**[Test build #50570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50570/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178431864
**[Test build #50554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50554/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178429585
**[Test build #2489 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2489/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178765823
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178456346
**[Test build #2489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2489/consoleFull)** for PR 11019 at commit [`2c2b007`](https://github.com/apache/spark/commit/2c2b0079d4397cb59a72a8f4631d6870b54ff0c4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org