You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Alan Woodward (Jira)" <ji...@apache.org> on 2021/09/13 11:07:00 UTC
[jira] [Commented] (LUCENE-8638) Remove deprecated code in main
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414139#comment-17414139 ]
Alan Woodward commented on LUCENE-8638:
---------------------------------------
Huh, I got unsubscribed from this somehow and missed all the fun. Thanks [~sokolov] for pushing this over the finish line!
I have one query, concerning the `haversin()` function in expressions. I don't think we should change value of this function, CHANGES entry or no - it's too easy for it to be part of a more complicated script that will just stop working in very confusing ways on upgrade. I think instead we can delegate to the non-deprecated method and then just multiple by 1000 to keep the existing contract - does this make sense?
> Remove deprecated code in main
> ------------------------------
>
> Key: LUCENE-8638
> URL: https://issues.apache.org/jira/browse/LUCENE-8638
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Blocker
> Fix For: main (9.0)
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> There are a number of deprecations in master that should be removed. This issue is to keep track of deprecations as a whole, some individual deprecations may require their own issues.
>
> Work on this issue should be pushed to the `master-deprecations` branch on gitbox
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org