You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by scwf <gi...@git.apache.org> on 2015/01/17 15:45:29 UTC
[GitHub] spark pull request: [SPARK-4937][SQL] Comment for the newly optimi...
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/4086
[SPARK-4937][SQL] Comment for the newly optimization rules in `BooleanSimplification`
Follow up of #3778
/cc @rxin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scwf/spark commentforspark-4937
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4086.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4086
----
commit 2d3406e63dfd8e527fd2f6ed9fc27cc342a51459
Author: scwf <wa...@huawei.com>
Date: 2015-01-17T14:33:07Z
added comment for spark-4937
commit aaf89f64333d2a9692a1068d0165c36128744d42
Author: scwf <wa...@huawei.com>
Date: 2015-01-17T14:34:57Z
code style issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4937][SQL] Comment for the newly optimi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4086
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4937][SQL] Comment for the newly optimi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4086#issuecomment-70369529
[Test build #25702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25702/consoleFull) for PR 4086 at commit [`aaf89f6`](https://github.com/apache/spark/commit/aaf89f64333d2a9692a1068d0165c36128744d42).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4937][SQL] Comment for the newly optimi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4086#issuecomment-70371913
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25702/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4937][SQL] Comment for the newly optimi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4086#issuecomment-70389973
Merging in master. I will submit a PR to update the description to make it more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4937][SQL] Comment for the newly optimi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4086#issuecomment-70371911
[Test build #25702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25702/consoleFull) for PR 4086 at commit [`aaf89f6`](https://github.com/apache/spark/commit/aaf89f64333d2a9692a1068d0165c36128744d42).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org