You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/22 03:54:53 UTC

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7541: Problem AbstractBootstrapInitializerTest#init solved

terrymanu commented on a change in pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#discussion_r492461066



##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/init/impl/AbstractBootstrapInitializer.java
##########
@@ -55,6 +55,8 @@
 @Slf4j
 public abstract class AbstractBootstrapInitializer implements BootstrapInitializer {
     
+    private ShardingSphereProxy shardingSphereProxy = new ShardingSphereProxy();

Review comment:
       It is better to make the field as final




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org