[GitHub] [nifi] gresockj commented on a change in pull request #5807: NIFI-9064: Support Oracle timestamp when `Use Avro Logical Types` is true for ExecuteSQLRecord and QueryDatabaseTableRecord

[GitBox <gi...@apache.org>]

gresockj commented on a change in pull request #5807:
URL: https://github.com/apache/nifi/pull/5807#discussion_r816872844



##########
File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##########
@@ -136,13 +138,12 @@ protected Record createRecord(final ResultSet rs) throws SQLException {
 
         for (final RecordField field : schema.getFields()) {
             final String fieldName = field.getFieldName();
-
+            RecordFieldType fieldType = field.getDataType().getFieldType();

Review comment:
       I think `fieldType` can even be `final` here

##########
File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##########
@@ -424,17 +420,14 @@ private static DataType getArrayBaseType(final Array array, final boolean useLog
             if (valueToLookAt instanceof BigInteger) {
                 return RecordFieldType.BIGINT.getDataType();
             }
-            if (valueToLookAt instanceof Integer) {

Review comment:
       Good catch finding the duplication from above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org