You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/12 15:46:49 UTC

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5788: Migrate IntImm & FloatImm ObjectRef to not-null

ANSHUMAN87 commented on a change in pull request #5788:
URL: https://github.com/apache/incubator-tvm/pull/5788#discussion_r439498500



##########
File path: src/arith/rewrite_simplify.cc
##########
@@ -123,7 +123,7 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const AddNode* op) {
   // Pattern var to match any expression
   PVar<PrimExpr> x, y, z, b1, b2, s1, s2;
   // Pattern var match IntImm
-  PVar<IntImm> c1, c2, c3;
+  PVarOpt<Optional<IntImm>> c1, c2, c3;

Review comment:
       Yes, I agree. It is only to accommodate absent of default constructor. However the behaviour don't violate with PVar I think. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org