[jira] [Commented] (SOLR-12734) Don't capture metrics for certain admin handlers

["Cassandra Targett (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603665#comment-16603665 ] 

Cassandra Targett commented on SOLR-12734:
------------------------------------------

IMO, the experience of one user is sometimes not enough data to make a decision like this. Sometimes one user is just one that thinks differently from the person who implemented it. Are lots of users confused?

No matter what, we disable some and then some user later is going to want all the stats for all the handlers and then we're in the same position as with example schemas. We tweak and tweak and tweak and then absolutely no one is happy.

Instead of completely disabling some metrics we should instead explore making it easier to get to the metrics a user thinks are most important. I get the point about noise, but let's think of ways to reduce it with other ways - maybe user-controlled tags? 

> Don't capture metrics for certain admin handlers
> ------------------------------------------------
>
>                 Key: SOLR-12734
>                 URL: https://issues.apache.org/jira/browse/SOLR-12734
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>            Assignee: Varun Thacker
>            Priority: Major
>
> I just had a user who confused the metrics we show for the zookeeper admin handler and think this was actual ZooKeeper metrics
>  
> For example metrics like these
> {code:java}
> "ADMIN./admin/zookeeper.clientErrors":{
> "count":0,
> "meanRate":0.0,
> "1minRate":0.0,
> "5minRate":0.0,
> "15minRate":0.0},
> "ADMIN./admin/zookeeper.errors":{
> "count":0,
> "meanRate":0.0,
> "1minRate":0.0,
> "5minRate":0.0,
> "15minRate":0.0},
> "ADMIN./admin/zookeeper.handlerStart":1536093060895,
> "ADMIN./admin/zookeeper.requestTimes":{
> "count":0,
> "meanRate":0.0,
> "1minRate":0.0,
> "5minRate":0.0,
> "15minRate":0.0,
> "min_ms":0.0,
> "max_ms":0.0,
> "mean_ms":0.0,
> "median_ms":0.0,
> "stddev_ms":0.0,
> "p75_ms":0.0,
> "p95_ms":0.0,
> "p99_ms":0.0,
> "p999_ms":0.0},{code}
> Thinking about this these metrics don't seem useful at all to me and would just confuse users
>  
> My proposal is to remove the metrics we display for the following admin handlers as they don't add any value and reduces the verbosity of the response 
> {code:java}
> /admin/info
> /admin/configs
> /admin/zookeeper
> /admin/zookeeper/status
> /admin/info/system
> /admin/metrics/history
> /admin/autoscaling
> /admin/autoscaling/history
> /admin/autoscaling/diagnostics
> /admin/autoscaling/suggestions{code}
> Admin handlers that we should still keep metrics . These might be helpful to some user who wants to see how many requests fail, how many times is my monitoring tool calling the metrics API etc
> {code:java}
> /admin/health
> /admin/authentication
> /admin/authorization
> /admin/metrics
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org