You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2001/01/11 09:17:42 UTC

Re: CVS update: subversion/subversion/clients/win32/svn_com SVNStatus.rgs SVNStatus.h SVNStatus.cpp SVNCOMps.mk SVNCOMps.def SVNCOM.rc SVNCOM.idl SVNCOM.def SVNCOM.cpp svn_comCP.h svn_com.dsp SVN.rgs SVN.h SVN.cpp StdAfx.h StdAfx.cpp resource.h misc.h misc.cpp MarshalArray.h dlldatax.h dlldatax.c

rassilon@tigris.org wrote:

>   #ifndef __SVNSTATUS_H_
>   #define __SVNSTATUS_H_
>   #pragma once

Isn't this a bit of overkill? I mean, either the #ifdef or the #pragma 
is fine, but why use both? (FWIW, I'd use only the #ifdef.)

Another thing ... and this will start the old flame war again, yeah ... 
could we please decide to at least not use names that start with 
underscores -- specifically, those that match /^((__)|(_[A-Z]))/ -- 
because they are reserved in both C and C++?

Yes, yes, I know they "can't possibly" clash with anything provided by 
the compiler and standard libraries ...

-- 
Brane ďż˝ibej
    home:   <br...@xbc.nu>             http://www.xbc.nu/brane/
    work:   <br...@hermes.si>   http://www.hermes-softlab.com/
     ACM:   <br...@acm.org>            http://www.acm.org/