You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by bu...@apache.org on 2006/12/12 19:16:20 UTC
DO NOT REPLY [Bug 41163] New: - [PATCH] Fixed publish notification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
Summary: [PATCH] Fixed publish notification
Product: Lenya
Version: 1.4
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: Default Publication
AssignedTo: dev@lenya.apache.org
ReportedBy: richard.frovarp@sendit.nodak.edu
Publish.java from default publication was looking for an event of submit,
instead of publish. Also the sessions were not equal between getSession and the
one generated from the document in the factory.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 41163] - [PATCH] Fixed publish notification
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
richard.frovarp@sendit.nodak.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19248|0 |1
is obsolete| |
------- Additional Comments From richard.frovarp@sendit.nodak.edu 2006-12-12 12:13 -------
Created an attachment (id=19250)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=19250&action=view)
Gets previous version to get submitter
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 41163] - [PATCH] Fixed publish notification
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
thorsten@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.4 |2.0
Version|1.4 |2.0
------- Additional Comments From thorsten@apache.org 2007-07-16 01:58 -------
Renaming Lenya 1.4 to 2.0
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 41163] - [PATCH] Fixed publish notification
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
------- Additional Comments From richard.frovarp@sendit.nodak.edu 2006-12-12 10:16 -------
Created an attachment (id=19248)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=19248&action=view)
Fix to send publish notification
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 41163] - [PATCH] Fixed publish notification
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
------- Additional Comments From andreas@apache.org 2006-12-12 11:28 -------
(In reply to comment #0)
> Also the sessions were not equal between getSession and the
> one generated from the document in the factory.
That's indeed a problem. I'll try to find the reason why the sessions are not
the same.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 41163] - [PATCH] Fixed publish notification
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
------- Additional Comments From richard.frovarp@sendit.nodak.edu 2006-12-12 12:17 -------
(In reply to comment #3)
> (In reply to comment #0)
> > Also the sessions were not equal between getSession and the
> > one generated from the document in the factory.
>
> That's indeed a problem. I'll try to find the reason why the sessions are not
> the same.
I did go and do a test case where I got both of the sessions to be the same,
using the defautl factory method. I didn't get an error. However, I also didn't
get the notification sent out. The method in the patch does get the notification
to be sent and doesn't have a problem with mismatched sessions.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 41163] - [PATCH] Fixed publish notification
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
------- Additional Comments From andreas@apache.org 2006-12-12 11:27 -------
Thanks for the patch!
But I don't quite understand this:
- // we assume that the document has been submitted, otherwise we do nothing
- if (version.getEvent().equals("submit")) {
+ // we assume that the document has been published, otherwise we do nothing
+ if (version.getEvent().equals("publish")) {
My intention was to send a notification to the user who submitted the document.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 41163] - [PATCH] Fixed publish notification
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
------- Additional Comments From richard.frovarp@sendit.nodak.edu 2006-12-12 12:13 -------
(In reply to comment #2)
> Thanks for the patch!
>
> But I don't quite understand this:
>
> - // we assume that the document has been submitted, otherwise we do
nothing
> - if (version.getEvent().equals("submit")) {
> + // we assume that the document has been published, otherwise we do
nothing
> + if (version.getEvent().equals("publish")) {
>
> My intention was to send a notification to the user who submitted the document.
Okay, I now see what you were after. However, the latest version is the
published version. What is really desired is the version before the current
version. I will submit another patch for that case.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 41163] - [PATCH] Fixed publish notification
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41163>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41163
andreas@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From andreas@apache.org 2006-12-18 08:56 -------
Thanks a lot for the patch!
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org