You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@wandisco.com> on 2013/05/19 19:05:20 UTC

Re: svn commit: r1484251 - /subversion/branches/invoke-diff-cmd-feature/subversion/svn/log-cmd.c

On 19.05.2013 11:57, gbg@apache.org wrote:
> Author: gbg
> Date: Sun May 19 09:57:35 2013
> New Revision: 1484251
>
> URL: http://svn.apache.org/r1484251
> Log:
> Update call to svn_client_diff_peg6 to svn_client_diff_peg7.
>
> * subversion/svn/log-cmd.c 
>   (svn_client_diff_peg7): Update call to svn_client_diff_peg6 to
>     svn_client_diff_peg7.
>
> Modified:
>     subversion/branches/invoke-diff-cmd-feature/subversion/svn/log-cmd.c
>
> Modified: subversion/branches/invoke-diff-cmd-feature/subversion/svn/log-cmd.c
> URL: http://svn.apache.org/viewvc/subversion/branches/invoke-diff-cmd-feature/subversion/svn/log-cmd.c?rev=1484251&r1=1484250&r2=1484251&view=diff
> ==============================================================================
> --- subversion/branches/invoke-diff-cmd-feature/subversion/svn/log-cmd.c (original)
> +++ subversion/branches/invoke-diff-cmd-feature/subversion/svn/log-cmd.c Sun May 19 09:57:35 2013
> @@ -122,7 +122,7 @@ display_diff(const svn_log_entry_t *log_
>    end_revision.value.number = log_entry->revision;
>  
>    SVN_ERR(svn_stream_puts(outstream, "\n"));
> -  SVN_ERR(svn_client_diff_peg6(diff_options,
> +  SVN_ERR(svn_client_diff_peg7(diff_options,
>                                 target_path_or_url,
>                                 target_peg_revision,
>                                 &start_revision, &end_revision,
> @@ -140,7 +140,8 @@ display_diff(const svn_log_entry_t *log_
>                                 outstream,
>                                 errstream,
>                                 NULL,
> -                               ctx, pool));
> +			       NULL,
> +			       ctx, pool));
>    SVN_ERR(svn_stream_puts(outstream, _("\n")));
>    return SVN_NO_ERROR;
>  }

The last hunk contains tabs. There should be no tabs in our source
files, ever.

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com


Re: svn commit: r1484251 - /subversion/branches/invoke-diff-cmd-feature/subversion/svn/log-cmd.c

Posted by Daniel Shahaf <da...@apache.org>.
On Sun, May 19, 2013 at 07:05:20PM +0200, Branko Čibej wrote:
> The last hunk contains tabs. There should be no tabs in our source
> files, ever.

(except Makefile)