You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <id...@twitter.com> on 2013/08/23 05:56:32 UTC
Review Request 13764: Add resource checks to slave recovery tests to ensure
resources are re-offered after restarts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/slave_recovery_tests.cpp 548e8c0
Diff: https://reviews.apache.org/r/13764/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 13764: Add resource checks to slave recovery tests to
ensure resources are re-offered after restarts.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/#review25575
-----------------------------------------------------------
ian can you get to the comments today? we would like to include this in our 0.14.0-rc2 release.
- Vinod Kone
On Aug. 23, 2013, 3:56 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13764/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2013, 3:56 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 548e8c0
>
> Diff: https://reviews.apache.org/r/13764/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 13764: Add resource checks to slave recovery tests to
ensure resources are re-offered after restarts.
Posted by Ian Downes <id...@twitter.com>.
> On Aug. 24, 2013, 1:21 a.m., Vinod Kone wrote:
> > Did you run this repeatedly in a loop on both osx and linux?
Yes 100 times on linux and 20 on osx.
> On Aug. 24, 2013, 1:21 a.m., Vinod Kone wrote:
> > src/tests/slave_recovery_tests.cpp, line 745
> > <https://reviews.apache.org/r/13764/diff/1/?file=344130#file344130line745>
> >
> > ditto..kill
In this test the task immediately exits and we await the gc before stopping and restarting the slave so we can expect multiple offers.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/#review25488
-----------------------------------------------------------
On Aug. 23, 2013, 3:56 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13764/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2013, 3:56 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 548e8c0
>
> Diff: https://reviews.apache.org/r/13764/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 13764: Add resource checks to slave recovery tests to
ensure resources are re-offered after restarts.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/#review25488
-----------------------------------------------------------
Did you run this repeatedly in a loop on both osx and linux?
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49932>
Now that you have a expectation on offers after the slave restarts below, you shouldn't be receiving any more offers. So kill WillRepeatedly().
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49934>
move this to before the slave is restarted, because theoretically offers could be offered by the time you are here!
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49930>
s/Scheduler/Master/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49933>
ditto..kill this.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49935>
ditto..move
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49936>
s/Scheduler/Master/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49937>
ditto..kill
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49938>
ditto..move up
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49939>
ditto..kill
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49940>
ditto..move
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49941>
ditto..kill
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49942>
ditto..move
- Vinod Kone
On Aug. 23, 2013, 3:56 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13764/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2013, 3:56 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 548e8c0
>
> Diff: https://reviews.apache.org/r/13764/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 13764: Add resource checks to slave recovery tests to
ensure resources are re-offered after restarts.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/#review25698
-----------------------------------------------------------
This was reverted to un-break master.
I see there were a few reviews out to fix this, so those can be discarded in favor of re-sending this change out.
Thanks!
- Ben Mahler
On Aug. 26, 2013, 10:59 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13764/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 10:59 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 548e8c0
>
> Diff: https://reviews.apache.org/r/13764/diff/
>
>
> Testing
> -------
>
> make check # repeat 100x on linux and 20x on osx
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 13764: Add resource checks to slave recovery tests to
ensure resources are re-offered after restarts.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/#review25621
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 26, 2013, 10:59 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13764/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 10:59 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 548e8c0
>
> Diff: https://reviews.apache.org/r/13764/diff/
>
>
> Testing
> -------
>
> make check # repeat 100x on linux and 20x on osx
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 13764: Add resource checks to slave recovery tests to
ensure resources are re-offered after restarts.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/#review25626
-----------------------------------------------------------
committed. pls mark this as submitted.
- Vinod Kone
On Aug. 26, 2013, 10:59 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13764/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 10:59 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 548e8c0
>
> Diff: https://reviews.apache.org/r/13764/diff/
>
>
> Testing
> -------
>
> make check # repeat 100x on linux and 20x on osx
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 13764: Add resource checks to slave recovery tests to
ensure resources are re-offered after restarts.
Posted by Ian Downes <id...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/
-----------------------------------------------------------
(Updated Aug. 26, 2013, 10:59 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/slave_recovery_tests.cpp 548e8c0
Diff: https://reviews.apache.org/r/13764/diff/
Testing (updated)
-------
make check # repeat 100x on linux and 20x on osx
Thanks,
Ian Downes
Re: Review Request 13764: Add resource checks to slave recovery tests to
ensure resources are re-offered after restarts.
Posted by Ian Downes <id...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/
-----------------------------------------------------------
(Updated Aug. 26, 2013, 10:59 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 548e8c0
Diff: https://reviews.apache.org/r/13764/diff/
Testing
-------
make check
Thanks,
Ian Downes