You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2025/01/08 02:25:27 UTC
Re: [PR] [Fix] [Kafka Source] kafka source use topic as table name instead of fullName [seatunnel]
Hisoka-X commented on code in PR #8401:
URL: https://github.com/apache/seatunnel/pull/8401#discussion_r1906254361
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfig.java:
##########
@@ -205,7 +205,8 @@ private ConsumerMetadata createConsumerMetadata(ReadonlyConfig readonlyConfig) {
private CatalogTable createCatalogTable(ReadonlyConfig readonlyConfig) {
Optional<Map<String, Object>> schemaOptions =
readonlyConfig.getOptional(TableSchemaOptions.SCHEMA);
- TablePath tablePath = TablePath.of(readonlyConfig.get(TOPIC));
+ String topic = readonlyConfig.get(TOPIC).replace(".", "_");
+ TablePath tablePath = TablePath.of("kafka", topic);
Review Comment:
Hi why not use `TablePath.of("kafka", readonlyConfig.get(TOPIC))`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org