You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/06/24 21:02:27 UTC
[GitHub] storm pull request #2736: MINOR: Mkdir for storm.home when running LocalClus...
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2736
MINOR: Mkdir for storm.home when running LocalCluster
Turns out Rocksdb doesn't handle creating parent directories, so https://github.com/apache/storm/pull/2728 doesn't prevent it from throwing an exception when Nimbus is started.
That said, we're still getting an exception when Nimbus is started from https://github.com/apache/storm/blob/4137328b75c06771f84414c3c2113e2d1c757c08/storm-server/src/main/java/org/apache/storm/metricstore/rocksdb/StringMetadataCache.java#L64, so this doesn't by itself prevent the metrics store from failing to initialize in tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm mkdir-storm-local
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2736.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2736
----
commit 3a66a47b45de82260ed6731f5af469da11165690
Author: Stig Rohde Døssing <sr...@...>
Date: 2018-06-24T20:57:38Z
MINOR: Mkdir for storm.home when running LocalCluster
----
---
[GitHub] storm pull request #2736: MINOR: Mkdir for storm.home when running LocalClus...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2736
---
[GitHub] storm issue #2736: MINOR: Mkdir for storm.home when running LocalCluster
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2736
@srdo Thanks for the patch. Merged into master.
---