You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Brian Bockelman (JIRA)" <ji...@apache.org> on 2009/03/26 16:50:11 UTC
[jira] Created: (HADOOP-5579) libhdfs does not set errno correctly
libhdfs does not set errno correctly
------------------------------------
Key: HADOOP-5579
URL: https://issues.apache.org/jira/browse/HADOOP-5579
Project: Hadoop Core
Issue Type: Bug
Components: dfs, libhdfs
Affects Versions: 0.19.1
Reporter: Brian Bockelman
Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5579) libhdfs does not set errno correctly
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5579:
----------------------------------
Fix Version/s: (was: 0.21.0)
0.19.2
Committed to 0.19 and 0.20 branches
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707596#action_12707596 ]
Chris Douglas commented on HADOOP-5579:
---------------------------------------
bq. Why did you commit this without a test or justification?
You're right; it would be useful to have unit tests validating errno, particularly since it's already been broken accidentally.
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703118#action_12703118 ]
Brian Bockelman commented on HADOOP-5579:
-----------------------------------------
Bump -- can someone take a look at this again? I think it's ready to go.
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707401#action_12707401 ]
Nigel Daley commented on HADOOP-5579:
-------------------------------------
Chris,
{quote}
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
{quote}
Why did you commit this without a test or justification?
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693500#action_12693500 ]
Brian Bockelman commented on HADOOP-5579:
-----------------------------------------
Contrib test failure appears to be unrelated?
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693416#action_12693416 ]
Brian Bockelman commented on HADOOP-5579:
-----------------------------------------
Hey Chris,
I'd rather keep the two separate - this one is for libhdfs changes needed, the others are for HDFS changes needed.
At a more practical level, I don't know what I need to do to fix HADOOP-5580/5581 -- haven't hacked the code there yet. I was hoping one of the core devs would have an idea.
Brian
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5579) libhdfs does not set errno correctly
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Bockelman updated HADOOP-5579:
------------------------------------
Status: Patch Available (was: Open)
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5579) libhdfs does not set errno correctly
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5579:
-------------------------------------
Fix Version/s: 0.19.2
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703943#action_12703943 ]
Raghu Angadi commented on HADOOP-5579:
--------------------------------------
+1. I don't use libhdfs myself, but the patch makes sense. Do these error codes exist on other platforms (Solaris, etc)? If Hudson compiles libhdfs, then it is already tested for Solaris.
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5579) libhdfs does not set errno correctly
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Bockelman updated HADOOP-5579:
------------------------------------
Attachment: HADOOP-5579.patch
Fixes the AccessControlException.
Also correctly sets the errno for QuotaExceededException and FileNotFoundException. Unfortunately, DFSClient does not correctly raise these exceptions (yet).
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706153#action_12706153 ]
Hudson commented on HADOOP-5579:
--------------------------------
Integrated in Hadoop-trunk #827 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/827/])
. Set errno correctly in libhdfs for permission, quota, and FNF
conditions. Contributed by Brian Bockelman.
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.21.0
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5579) libhdfs does not set errno correctly
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur reassigned HADOOP-5579:
----------------------------------------
Assignee: Brian Bockelman
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706878#action_12706878 ]
Hudson commented on HADOOP-5579:
--------------------------------
Integrated in Hadoop-trunk #828 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/828/])
Move to 0.19.2
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Craig Macdonald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689557#action_12689557 ]
Craig Macdonald commented on HADOOP-5579:
-----------------------------------------
+1 for this patch. Looks good.
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706001#action_12706001 ]
Brian Bockelman commented on HADOOP-5579:
-----------------------------------------
Hey Chris,
These would be good additions to either 0.19.x or 0.20.x branches; they should apply cleanly to both (maybe with offsets). The exception detection isn't done through string comparison so the fact that FNF doesn't get thrown in 19/20 should hurt anything.
I don't know how critical it is or what policies are needed to apply patches to a branch instead of trunk. I do know that this patch is in our locally-maintained patchset.
Brian
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.21.0
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5579) libhdfs does not set errno
correctly
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693427#action_12693427 ]
Hadoop QA commented on HADOOP-5579:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12403721/HADOOP-5579.patch
against trunk revision 759398.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/72/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/72/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/72/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/72/console
This message is automatically generated.
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5579) libhdfs does not set errno correctly
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5579:
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.19.2)
0.21.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed this. Thanks, Brian
I only committed this to 0.21 since the FNF exception is only thrown in that branch, per HADOOP-5581. However, not setting EACCES remains a problem in 0.19 per HADOOP-4393, right? Should the current patch be committed further back or do the 0.19 and 0.20 branches need a different patch?
> libhdfs does not set errno correctly
> ------------------------------------
>
> Key: HADOOP-5579
> URL: https://issues.apache.org/jira/browse/HADOOP-5579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.21.0
>
> Attachments: HADOOP-5579.patch
>
>
> Due to a change in the package name of the AccessControlException, libhdfs no longer sets errno=EACCES when a permission occurs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.