[jira] [Commented] (AMBARI-15719) Make list of reassignable components stack driven instead of hardcoding them in the UI code

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-15719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232086#comment-15232086 ] 

Hadoop QA commented on AMBARI-15719:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12797620/AMBARI-15719.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 7 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server ambari-web.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6306//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6306//console

This message is automatically generated.

> Make list of reassignable components stack driven instead of hardcoding them in the UI code
> -------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-15719
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15719
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-server, ambari-web
>    Affects Versions: trunk
>            Reporter: Di Li
>            Assignee: Di Li
>             Fix For: trunk
>
>         Attachments: AMBARI-15719.patch
>
>
> When a component is reassignable, the Ambari web UI adds the "Move" menu item to the component menu on the host page.
> The logic on whether a component should be displayed with the "Move" menu item is currently controlled by the following hardcoded list.
> /** @property {Boolean} isReassignable - component supports reassign action **/
>   isReassignable: function() {
>     return ['NAMENODE', 'SECONDARY_NAMENODE', 'JOBTRACKER', 'RESOURCEMANAGER', 'APP_TIMELINE_SERVER', 'OOZIE_SERVER', 'WEBHCAT_SERVER', 'HIVE_SERVER', 'HIVE_METASTORE', 'MYSQL_SERVER', 'METRICS_COLLECTOR'].contains(this.get('componentName'));
>   }.property('componentName'),
> We should make the list stack driven by specify whether a component is reassignable via a flag in the metainfo.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)