You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "shruti2522 (via GitHub)" <gi...@apache.org> on 2025/03/02 12:03:36 UTC
[PR] datafusion-cli: add streaming state for printing logic [datafusion]
shruti2522 opened a new pull request, #14961:
URL: https://github.com/apache/datafusion/pull/14961
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #14886
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
code clean for new datafusion-cli printing logic
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- [x] added `OutputStream` struct encapsulating all the mut variables
- [x] additional tests
## Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2693488674
Thank you @shruti2522 for the work, we still need this feature, we revert it due to urgent release cycle for the new feature testing and bug fixes, actually we will add back the feature in this PR:
https://github.com/apache/datafusion/issues/14953
And you may need to rebase after it merged, i will take a look after it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "shruti2522 (via GitHub)" <gi...@apache.org>.
shruti2522 commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2692700043
Hi @alamb, please trigger the CI for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2695600414
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "shruti2522 (via GitHub)" <gi...@apache.org>.
shruti2522 commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2693447156
Hi @alamb , @zhuqi-lucas, I see that the most of the functions in the datafusion cli print format have been reverted, do we still need these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1978574819
##########
datafusion-cli/src/print_format.rs:
##########
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows<W: std::io::Write>(
Ok(())
}
+/// The state and methods for displaying output
Review Comment:
@shruti2522 May be after https://github.com/apache/datafusion/pull/14954 finalizing, you can open a PR to my branch, so we can review and merge then? @alamb I am also wandering how we can collaborate the work? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "shruti2522 (via GitHub)" <gi...@apache.org>.
shruti2522 commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1978519726
##########
datafusion-cli/src/print_format.rs:
##########
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows<W: std::io::Write>(
Ok(())
}
+/// The state and methods for displaying output
Review Comment:
Sure @alamb, how can I help with PR #14954?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1977876884
##########
datafusion-cli/src/print_format.rs:
##########
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows<W: std::io::Write>(
Ok(())
}
+/// The state and methods for displaying output
Review Comment:
This definitely looks like it is on the right track -- thank you @shruti2522
Can you perhaps try and migrate the old callsites to use this new code?
As @zhuqi-lucas mentions, there is another version of the PR here:
- https://github.com/apache/datafusion/pull/14954
I am hoping we can get the structure in https://github.com/apache/datafusion/pull/14954 cleaner before merging. Maybe you can help there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "shruti2522 (via GitHub)" <gi...@apache.org>.
shruti2522 commented on code in PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#discussion_r1978519726
##########
datafusion-cli/src/print_format.rs:
##########
@@ -153,6 +155,164 @@ fn format_batches_with_maxrows<W: std::io::Write>(
Ok(())
}
+/// The state and methods for displaying output
Review Comment:
Sure @alamb, how can I help in PR #14954?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "shruti2522 (via GitHub)" <gi...@apache.org>.
shruti2522 closed pull request #14961: datafusion-cli: add streaming state for printing logic
URL: https://github.com/apache/datafusion/pull/14961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] datafusion-cli: add streaming state for printing logic [datafusion]
Posted by "shruti2522 (via GitHub)" <gi...@apache.org>.
shruti2522 commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2696038414
Thanks @alamb, @zhuqi-lucas, I’ll rebase after PR #14953 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org