You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "jvz (via GitHub)" <gi...@apache.org> on 2024/01/01 20:37:23 UTC
[I] Add JSpecify annotations to defaults [logging-parent]
jvz opened a new issue, #88:
URL: https://github.com/apache/logging-parent/issues/88
As noted in https://issues.apache.org/jira/browse/LOG4J2-1477, JSpecify is the project specifying the one true nullability annotation standard. I experimented with creating copies of those annotations that use the JSR 305 nullability annotations to implement it, but it seems like it'd be easier to just use these annotations directly since they're only required at compile time. The use of these annotations would supersede any use of the old JSR annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add JSpecify annotations to defaults [logging-parent]
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on issue #88:
URL: https://github.com/apache/logging-parent/issues/88#issuecomment-1873540708
I have no idea if any support this yet. I like the annotation scheme at least, though, if we want to use our own packaged annotations instead based on JSR 305 like I tried out before. That approach at least works with existing tools until JSpecify is directly supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add JSpecify annotations to defaults [logging-parent]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz closed issue #88: Add JSpecify annotations to defaults
URL: https://github.com/apache/logging-parent/issues/88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add JSpecify annotations to defaults [logging-parent]
Posted by "GregDThomas (via GitHub)" <gi...@apache.org>.
GregDThomas commented on issue #88:
URL: https://github.com/apache/logging-parent/issues/88#issuecomment-1873829630
> which tools currently support those annotations? I am mostly interested in Eclipse, IDEA, Spotbugs and some tool like NullAway or Checker Framework t
IntelliJ supports it (JetBrains are a member of the jspecify group - https://jspecify.dev/about)
There's details on a fork of the checker framework at https://github.com/jspecify/jspecify-reference-checker
No idea on Spotbugs/Eclipse I'm afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add JSpecify annotations to defaults [logging-parent]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #88:
URL: https://github.com/apache/logging-parent/issues/88#issuecomment-1873488316
@jvz, can you list which tools currently support those annotations? I am mostly interested in Eclipse, IDEA, Spotbugs and some tool like NullAway or Checker Framework that guarantees that the code is NPE-free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add JSpecify annotations to defaults [logging-parent]
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on issue #88:
URL: https://github.com/apache/logging-parent/issues/88#issuecomment-1873624679
I just noticed that this can be done directly in Log4j for now. This will make it simpler to apply any rewrites to the annotations as tooling catches up. See https://github.com/apache/logging-log4j2/commit/2da4108da52653dbb43f00b0967f16917c6975c0 for the aliasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org