You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/19 02:04:35 UTC

[GitHub] [iceberg] rdblue opened a new pull request #1961: Spark: Add WRITE ORDERED BY command to set table order

rdblue opened a new pull request #1961:
URL: https://github.com/apache/iceberg/pull/1961


   This adds `ALTER TABLE ... WRITE ORDERED BY ...` to set the table order in Spark.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on pull request #1961: Spark: Add WRITE ORDERED BY command to set table order

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #1961:
URL: https://github.com/apache/iceberg/pull/1961#issuecomment-748883170


   Thanks, @rdblue!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1961: Spark: Add WRITE ORDERED BY command to set table order

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1961:
URL: https://github.com/apache/iceberg/pull/1961#discussion_r546608802



##########
File path: spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -69,13 +69,23 @@ statement
     : CALL multipartIdentifier '(' (callArgument (',' callArgument)*)? ')'                  #call
     | ALTER TABLE multipartIdentifier ADD PARTITION FIELD transform (AS name=identifier)?   #addPartitionField
     | ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform                        #dropPartitionField
+    | ALTER TABLE multipartIdentifier WRITE ORDERED BY order                                #setTableOrder
     ;
 
 callArgument
     : expression                    #positionalArgument
     | identifier '=>' expression    #namedArgument
     ;
 
+order
+    : fields+=orderField (',' fields+=orderField)*

Review comment:
       +1 on supporting expressions with and without parentheses. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #1961: Spark: Add WRITE ORDERED BY command to set table order

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1961:
URL: https://github.com/apache/iceberg/pull/1961#issuecomment-749101024


   Thanks for reviewing and merging!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi merged pull request #1961: Spark: Add WRITE ORDERED BY command to set table order

Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #1961:
URL: https://github.com/apache/iceberg/pull/1961


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org