You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/01/02 13:46:05 UTC
[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #310:
Add more automation to release candidate container
stevedlawrence opened a new pull request #310: Add more automation to release candidate container
URL: https://github.com/apache/incubator-daffodil/pull/310
- Install the wix shell script as part of creating the container instead
of getting it from the cloned daffodil repo. This avoids having a
broken symlink before the daffodil repo is cloned
- Change how we clone the svn repo to avoid unneeded directories
- svn remove any previous release candidates if they exist. Needed for
when doing an rc2, for example
- svn add the new release files so they are ready for commit if all
checks pass
- Put final steps in a script to automate release after all checks pass
- Add some missing suppression of popd output
DAFFODIL-2264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] stevedlawrence merged pull request #310: Add
more automation to release candidate container
Posted by GitBox <gi...@apache.org>.
stevedlawrence merged pull request #310: Add more automation to release candidate container
URL: https://github.com/apache/incubator-daffodil/pull/310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull
request #310: Add more automation to release candidate container
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #310: Add more automation to release candidate container
URL: https://github.com/apache/incubator-daffodil/pull/310#discussion_r362502472
##########
File path: containers/release-candidate/daffodil-release-candidate
##########
@@ -170,6 +165,8 @@ sbt \
"daffodil-japi/genjavadoc:doc" \
"daffodil-sapi/doc" \
+echo "Removing old release candidates..."
+svn delete --force $DAFFODIL_DIST_DIR/$VERSION-* 2> /dev/null
Review comment:
Yeah, I was being a little lazy here. The reason for the /dev/null redirect here is that there won't be an existing release candidate if this is the first one. So svn will output an error that there's nothing to delete. I just wanted to hide that, but you're right that this could potentially hide other real errors.
It's probably a better idea to check for the existence before deleting. I'll make the update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull
request #310: Add more automation to release candidate container
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on a change in pull request #310: Add more automation to release candidate container
URL: https://github.com/apache/incubator-daffodil/pull/310#discussion_r362499177
##########
File path: containers/release-candidate/daffodil-release-candidate
##########
@@ -170,6 +165,8 @@ sbt \
"daffodil-japi/genjavadoc:doc" \
"daffodil-sapi/doc" \
+echo "Removing old release candidates..."
+svn delete --force $DAFFODIL_DIST_DIR/$VERSION-* 2> /dev/null
Review comment:
All this piping errors to dev null seems very problematic to me. Under maintenance if one goofs up the pushd/popd pairings, or goof up the definitions of things like $DAFFODIL_DIST_DIR you won't get any diagnostics. At least not from these commands that will fail. So long as that's not a problem (because the errors would be obvious elsewhere in the script) then I'm ok with it I guess.
If the script is mostly straight line code, then there's little once can mess up under maintenance, so my concern may be unwarranted.
Is there a less fragile way to do this? E.g., just redirect to a temp file,.....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services