You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ashb (via GitHub)" <gi...@apache.org> on 2025/08/12 10:32:49 UTC
[PR] [v3-0-test] Allow failure callbacks for stuck in queued TIs that fail (#53435) [airflow]
ashb opened a new pull request, #54401:
URL: https://github.com/apache/airflow/pull/54401
In issue #51301, it was reported that failure callbacks do not run for task instances that get stuck in queued and fail in Airflow 2.10.5. This is happening due to the changes introduced in PR #43520 . In this PR, logic was introduced to requeue tasks that get stuck in queued (up to two times by default) before failing them.
Previously, the executor's fail method was called when the task needed to be failed after max requeue attempts. This was replaced by the task instance's set_state method in the PR ti.set_state(TaskInstanceState.FAILED, session=session). Without the executor's fail method being called, failure callbacks will not be executed for such task instances. Therefore, I changed the code to call the executor's fail method instead in Airflow 3.
(cherry picked from commit 6da77b1fdfc0b51762b47638489e752384911758)
Co-authored-by: Karen Braganza <ka...@gmail.com>
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-0-test] Allow failure callbacks for stuck in queued TIs that fail (#53435) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #54401:
URL: https://github.com/apache/airflow/pull/54401#discussion_r2273160896
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2054,14 +2055,45 @@ def _maybe_requeue_stuck_ti(self, *, ti, session):
"Task requeue attempts exceeded max; marking failed. task_instance=%s",
ti,
)
+ msg = f"Task was requeued more than {self._num_stuck_queued_retries} times and will be failed."
session.add(
Log(
event="stuck in queued tries exceeded",
task_instance=ti.key,
- extra=f"Task was requeued more than {self._num_stuck_queued_retries} times and will be failed.",
+ extra=msg,
)
)
- ti.set_state(TaskInstanceState.FAILED, session=session)
+
+ try:
+ dag = self.scheduler_dag_bag.get_dag_for_run(dag_run=ti.dag_run, session=session)
Review Comment:
```suggestion
dag = self.scheduler_dag_bag. get_dag(dag_run=ti.dag_run, session=session)
```
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2054,14 +2055,45 @@ def _maybe_requeue_stuck_ti(self, *, ti, session):
"Task requeue attempts exceeded max; marking failed. task_instance=%s",
ti,
)
+ msg = f"Task was requeued more than {self._num_stuck_queued_retries} times and will be failed."
session.add(
Log(
event="stuck in queued tries exceeded",
task_instance=ti.key,
- extra=f"Task was requeued more than {self._num_stuck_queued_retries} times and will be failed.",
+ extra=msg,
)
)
- ti.set_state(TaskInstanceState.FAILED, session=session)
+
+ try:
+ dag = self.scheduler_dag_bag.get_dag_for_run(dag_run=ti.dag_run, session=session)
Review Comment:
```suggestion
dag = self.scheduler_dag_bag.get_dag(dag_run=ti.dag_run, session=session)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-0-test] Allow failure callbacks for stuck in queued TIs that fail (#53435) [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #54401:
URL: https://github.com/apache/airflow/pull/54401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org