You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/11 01:28:28 UTC

[GitHub] [dolphinscheduler] zhuangchong commented on a diff in pull request #9976: [Fix-9975] The selected task instance was recreated when the Master service fail…

zhuangchong commented on code in PR #9976:
URL: https://github.com/apache/dolphinscheduler/pull/9976#discussion_r869794812


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1953,10 +1953,10 @@ private boolean checkTaskQueue() {
      * is new process instance
      */
     private boolean isNewProcessInstance() {
-        if (ExecutionStatus.RUNNING_EXECUTION == processInstance.getState() && processInstance.getRunTimes() == 1) {
-            return true;
-        } else {
+        if (ExecutionStatus.RUNNING_EXECUTION == processInstance.getState() && processInstance.getRunTimes() >= 1) {

Review Comment:
   Returns the expression result directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org