You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Patil <pr...@gmail.com> on 2023/02/17 06:54:57 UTC
Review Request 74309: RANGER-4084: Use the exact login ID in the header instead of capitalising the first character
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74309/
-----------------------------------------------------------
Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, and Mugdha Varadkar.
Bugs: RANGER-4084
https://issues.apache.org/jira/browse/RANGER-4084
Repository: ranger
Description
-------
The first character of the login ID in the header is being converted to uppercase,
and this might be confusing because it is possible to create users with same login Id but different case,
for ex :- temp_user and Temp_user, and when both the users are logged in, the header will display "Temp_user".
Hence, the login ID must be displayed exactly as it is.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx b054dc21e
Diff: https://reviews.apache.org/r/74309/diff/1/
Testing
-------
Tested changes on a cluster
Thanks,
Abhishek Patil
Re: Review Request 74309: RANGER-4084: Use the exact login ID in the header instead of capitalising the first character
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74309/#review225202
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On Feb. 17, 2023, 6:54 a.m., Abhishek Patil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74309/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2023, 6:54 a.m.)
>
>
> Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, and Mugdha Varadkar.
>
>
> Bugs: RANGER-4084
> https://issues.apache.org/jira/browse/RANGER-4084
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The first character of the login ID in the header is being converted to uppercase,
> and this might be confusing because it is possible to create users with same login Id but different case,
> for ex :- temp_user and Temp_user, and when both the users are logged in, the header will display "Temp_user".
> Hence, the login ID must be displayed exactly as it is.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx b054dc21e
>
>
> Diff: https://reviews.apache.org/r/74309/diff/1/
>
>
> Testing
> -------
>
> Tested changes on a cluster
>
>
> Thanks,
>
> Abhishek Patil
>
>