You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by stanlyxiang <gi...@git.apache.org> on 2017/05/03 06:04:02 UTC
[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...
GitHub user stanlyxiang opened a pull request:
https://github.com/apache/incubator-hawq/pull/1228
HAWQ-1449. HAWQ start/stop cluster should be able to start/stop RPS o…
…n standby node
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyxiang/incubator-hawq HAWQ-1449
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1228
----
commit 92483e029e6f3f2de589865c999ad6929d87d5c6
Author: stanlyxiang <st...@gmail.com>
Date: 2017-05-03T05:55:42Z
HAWQ-1449. HAWQ start/stop cluster should be able to start/stop RPS on standby node
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693437
--- Diff: tools/bin/hawq_ctl ---
@@ -1042,30 +1046,34 @@ class HawqStop:
return total_return_flag
- def _stop_rps(self, check_ret = True):
+ def _stop_rps(self, master_or_standby, acl_type):
--- End diff --
The same comment for "master_or_standby" parameter name in start_rps
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693788
--- Diff: tools/bin/hawq_ctl ---
@@ -737,25 +739,28 @@ class HawqStart:
logger.info("Segments started successfully")
return node_init.return_flag
- def _start_rps(self):
- logger.info("Start ranger plugin service")
+ def _start_rps(self, master_or_standby):
--- End diff --
fixed, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693412
--- Diff: tools/bin/hawq_ctl ---
@@ -737,25 +739,28 @@ class HawqStart:
logger.info("Segments started successfully")
return node_init.return_flag
- def _start_rps(self):
- logger.info("Start ranger plugin service")
+ def _start_rps(self, master_or_standby):
--- End diff --
It's better not identify parameter as "master_or_standby", since this looks like a boolean value, and is not valid for internal implementation of start_rps function. I'd recommend to rename it to "hostname" or other similar name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1228: HAWQ-1449. HAWQ start/stop cluster should be abl...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1228
@interma @linwen @zhangh43 @ictmalili pls review, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1228: HAWQ-1449. HAWQ start/stop cluster should be abl...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1228
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693454
--- Diff: tools/bin/hawq_ctl ---
@@ -737,25 +739,28 @@ class HawqStart:
logger.info("Segments started successfully")
return node_init.return_flag
- def _start_rps(self):
- logger.info("Start ranger plugin service")
+ def _start_rps(self, master_or_standby):
+ logger.info("Start ranger plugin service on %s" % master_or_standby)
cmd_str = "%s/ranger/bin/rps.sh start" % (self.GPHOME)
- result = remote_ssh(cmd_str, self.master_host_name, self.user)
+ result = remote_ssh(cmd_str, master_or_standby, self.user)
return result
- def start_rps(self):
- check_return_code(self._start_rps(), logger, \
- "Ranger plugin service start failed, exit", "Ranger plugin service started successfully")
+ def start_rps(self, master_or_standby):
--- End diff --
The same comment for "master_or_standby" parameter name in start_rps
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1228: HAWQ-1449. HAWQ start/stop cluster should be abl...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1228
Merged into master. Close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---