svn commit: r1374544 - in /creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app: Whisker.java analysis/LicenseAnalyst.java analysis/ResourceDefinitionException.java analysis/ResourceSourceAuditor.java

[rd...@apache.org]

Author: rdonkin
Date: Sat Aug 18 10:10:34 2012
New Revision: 1374544

URL: http://svn.apache.org/viewvc?rev=1374544&view=rev
Log:
Resolved PMD report for App, now clean

Modified:
    creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/Whisker.java
    creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/LicenseAnalyst.java
    creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java
    creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceSourceAuditor.java

Modified: creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/Whisker.java
URL: http://svn.apache.org/viewvc/creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/Whisker.java?rev=1374544&r1=1374543&r2=1374544&view=diff
==============================================================================
--- creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/Whisker.java (original)
+++ creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/Whisker.java Sat Aug 18 10:10:34 2012
@@ -28,7 +28,6 @@ import org.apache.creadur.whisker.fromxm
 import org.apache.creadur.whisker.model.Descriptor;
 import org.apache.creadur.whisker.scan.Directory;
 import org.apache.creadur.whisker.scan.FromFileSystem;
-import org.jdom.JDOMException;
 
 
 /**

Modified: creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/LicenseAnalyst.java
URL: http://svn.apache.org/viewvc/creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/LicenseAnalyst.java?rev=1374544&r1=1374543&r2=1374544&view=diff
==============================================================================
--- creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/LicenseAnalyst.java (original)
+++ creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/LicenseAnalyst.java Sat Aug 18 10:10:34 2012
@@ -154,6 +154,7 @@ public class LicenseAnalyst {
      * @param directory
      * @param collator
      */
+    @SuppressWarnings("PMD.EmptyIfStmt")
     private void analyseExtraLicenses(final Directory directory,
             final ResourceNamesCollator collator) {
         final Collection<String> actualResources = directory.getContents();
@@ -170,6 +171,7 @@ public class LicenseAnalyst {
      * @param directory
      * @param collator
      */
+    @SuppressWarnings("PMD.EmptyIfStmt")
     private void analyseMissingLicenses(final Directory directory,
             final ResourceNamesCollator collator) {
         final Collection<String> licensedResources = collator.getNames();

Modified: creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java
URL: http://svn.apache.org/viewvc/creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java?rev=1374544&r1=1374543&r2=1374544&view=diff
==============================================================================
--- creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java (original)
+++ creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java Sat Aug 18 10:10:34 2012
@@ -24,7 +24,7 @@ import java.util.Map;
 
 public final class ResourceDefinitionException extends Exception {
 
-    private final static String message(final Map<ResourceDefinitionError, Collection<ResourceDescription>> issues) {
+    private static String message(final Map<ResourceDefinitionError, Collection<ResourceDescription>> issues) {
         final StringBuilder builder = new StringBuilder("Resources definitions are incorrect. ");
         for (ResourceDefinitionError error: issues.keySet()) {
             if (!issues.get(error).isEmpty()) {

Modified: creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceSourceAuditor.java
URL: http://svn.apache.org/viewvc/creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceSourceAuditor.java?rev=1374544&r1=1374543&r2=1374544&view=diff
==============================================================================
--- creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceSourceAuditor.java (original)
+++ creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceSourceAuditor.java Sat Aug 18 10:10:34 2012
@@ -90,6 +90,7 @@ public class ResourceSourceAuditor exten
      * @see Visitor#visit(Resource)
      */
     @Override
+    @SuppressWarnings("PMD.EmptyIfStmt")
     public void visit(Resource resource) {
         if (lastLicense == null) {
             throw new IllegalArgumentException("Last license unexpectedly null for resource " + resource);