[GitHub] [incubator-doris] Youngwb commented on a change in pull request #2531: Spark return error to users when spark on doris query failed

[GitBox <gi...@apache.org>]

Youngwb commented on a change in pull request #2531: Spark return error to users when spark on doris query failed
URL: https://github.com/apache/incubator-doris/pull/2531#discussion_r361570888
 
 

 ##########
 File path: be/src/runtime/plan_fragment_executor.cpp
 ##########
 @@ -519,6 +520,10 @@ void PlanFragmentExecutor::update_status(const Status& status) {
                 _runtime_state->set_mem_limit_exceeded(status.get_error_msg());
             }
             _status = status;
+            if (_runtime_state->query_options().query_type == TQueryType::EXTERNAL) {
 
 Review comment:
   there is no need to check the  `status`, because at the beginning of this function, it already check the `status`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org