You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2013/07/24 21:19:08 UTC

Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/
-----------------------------------------------------------

Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Hollander.


Bugs: CLOUDSTACK-2133


Repository: cloudstack-git


Description
-------

The Cisco VNMC xml files are present under plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files present there needs to be included in the build package.


Diffs
-----

  packaging/centos63/cloud.spec 61e00bd 

Diff: https://reviews.apache.org/r/12912/diff/


Testing
-------

Tested 


Thanks,

Rayees Namathponnan


Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/#review24168
-----------------------------------------------------------

Ship it!


Ship It!

- edison su


On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12912/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 6:19 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Bugs: CLOUDSTACK-2133
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The Cisco VNMC xml files are present under plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files present there needs to be included in the build package.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 61e00bd 
> 
> Diff: https://reviews.apache.org/r/12912/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> File Attachments
> ----------------
> 
> updated with file permission from agent to common
>   https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/#review24169
-----------------------------------------------------------


Commit 97c9a9664f0a62101f022ef5a25de1c7082ff669 in branch refs/heads/4.2 from rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=97c9a96 ]

CLOUDSTACK-2133 - Cisco VNMC xml need copy to plugins/network-elements/cisco-vnmc/scripts/network/cisco during installation


- ASF Subversion and Git Services


On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12912/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 6:19 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Bugs: CLOUDSTACK-2133
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The Cisco VNMC xml files are present under plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files present there needs to be included in the build package.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 61e00bd 
> 
> Diff: https://reviews.apache.org/r/12912/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> File Attachments
> ----------------
> 
> updated with file permission from agent to common
>   https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/#review24157
-----------------------------------------------------------


Review 12912 PASSED the build test
The url of build cloudstack-master-with-patch #75 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/75/

- Jenkins Cloudstack.org


On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12912/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 6:19 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Bugs: CLOUDSTACK-2133
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The Cisco VNMC xml files are present under plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files present there needs to be included in the build package.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 61e00bd 
> 
> Diff: https://reviews.apache.org/r/12912/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> File Attachments
> ----------------
> 
> updated with file permission from agent to common
>   https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/#review24166
-----------------------------------------------------------


Commit a5d17c8dc76ee10de0e74bcd668e135579cb630e in branch refs/heads/master from rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a5d17c8 ]

CLOUDSTACK-2133 - Cisco VNMC xml need copy to plugins/network-elements/cisco-vnmc/scripts/network/cisco during installation


- ASF Subversion and Git Services


On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12912/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 6:19 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Hollander.
> 
> 
> Bugs: CLOUDSTACK-2133
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The Cisco VNMC xml files are present under plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files present there needs to be included in the build package.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 61e00bd 
> 
> Diff: https://reviews.apache.org/r/12912/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> File Attachments
> ----------------
> 
> updated with file permission from agent to common
>   https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/
-----------------------------------------------------------

(Updated July 29, 2013, 6:19 p.m.)


Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Hollander.


Changes
-------

Folowup fix for CLOUDSTACK-2133


Bugs: CLOUDSTACK-2133


Repository: cloudstack-git


Description
-------

The Cisco VNMC xml files are present under plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files present there needs to be included in the build package.


Diffs
-----

  packaging/centos63/cloud.spec 61e00bd 

Diff: https://reviews.apache.org/r/12912/diff/


Testing
-------

Tested 


File Attachments (updated)
----------------

updated with file permission from agent to common
  https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch


Thanks,

Rayees Namathponnan