You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/13 03:38:28 UTC

[GitHub] [pulsar] freeznet opened a new pull request #10563: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-client-original`

freeznet opened a new pull request #10563:
URL: https://github.com/apache/pulsar/pull/10563


   Fixes #9640
   Part 1
   
   ### Motivation
   
   Module `pulsar-client-admin-api` has been introduced in #9246, but it pulling in many dependencies.  
   
   Due to my mistaken ops on the git branch, the original PR #10513 has been closed, this PR will continue the work.
   
   ### Modifications
   
   remove `pulsar-client-original` from `pulsar-client-admin-api`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #10563: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-client-original`

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #10563:
URL: https://github.com/apache/pulsar/pull/10563#issuecomment-841636946


   @merlimat Can you review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] freeznet commented on pull request #10563: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-client-original`

Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #10563:
URL: https://github.com/apache/pulsar/pull/10563#issuecomment-840523402


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10563: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-client-original`

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10563:
URL: https://github.com/apache/pulsar/pull/10563


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10563: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-client-original`

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10563:
URL: https://github.com/apache/pulsar/pull/10563


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10563: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-client-original`

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #10563:
URL: https://github.com/apache/pulsar/pull/10563#discussion_r631747978



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/PulsarAdmin.java
##########
@@ -147,11 +146,6 @@ static PulsarAdminBuilder builder() {
      */
     String getServiceUrl();
 
-    /**
-     * @return the client Configuration Data that is being used
-     */
-    ClientConfigurationData getClientConfigData();
-

Review comment:
       We don't have a release that contains this API, it's ok here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org