[GitHub] [pulsar] eolivelli commented on a diff in pull request #15957: [fix][tests] TieredStorageConfigurationTests - clear system properties

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #15957:
URL: https://github.com/apache/pulsar/pull/15957#discussion_r901677944


##########
tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfigurationTests.java:
##########
@@ -217,9 +217,10 @@ public void overridePropertiesTest() {
         System.setProperty("jclouds.region", "jclouds-region");
         TieredStorageConfiguration config = new TieredStorageConfiguration(map);
         Properties properties = config.getOverrides();
-        System.out.println(properties.toString());
         assertEquals(properties.get("jclouds.region"), "jclouds-region");
         assertEquals(config.getServiceEndpoint(), "http://localhost");
         assertEquals(properties.get("jclouds.SystemPropertyA"), "A");
+        System.clearProperty("jclouds.SystemPropertyA");

Review Comment:
   makes sense



##########
tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfigurationTests.java:
##########
@@ -217,9 +217,10 @@ public void overridePropertiesTest() {
         System.setProperty("jclouds.region", "jclouds-region");
         TieredStorageConfiguration config = new TieredStorageConfiguration(map);
         Properties properties = config.getOverrides();
-        System.out.println(properties.toString());
         assertEquals(properties.get("jclouds.region"), "jclouds-region");
         assertEquals(config.getServiceEndpoint(), "http://localhost");
         assertEquals(properties.get("jclouds.SystemPropertyA"), "A");
+        System.clearProperty("jclouds.SystemPropertyA");
+        System.clearProperty("jclouds.region");

Review Comment:
   it theory there should be no "previous" value, because this is a system property



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org