You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/28 11:26:58 UTC
[GitHub] [airflow] potiuk opened a new pull request #21182: Display better error message when importing providers has errors
potiuk opened a new pull request #21182:
URL: https://github.com/apache/airflow/pull/21182
When there are import errors in providers we printed errors
in a folded group which lead to poor discovery of those errors.
Also with recent changes to Airflow main for upcoming 2.3 version
some errors might become more common when developing providers.
Specifically the way how to import Context in order to satisfy
MyPy and keep Airflow 2.1 compatibility is not obvious.
This change introduces helpful guideline to users adding new
providers:
* moving errors outside of the folded group with imports
* adding comment explaining what the errors are about
* adding message about backwards compatibility in case
errors happen during 2.1.0 backwards-compatibility check
* adding explanation and suggest a fix in the common Context
impport error
Note!!
For tests I am running it for now using "real" problematic case. I will rebase it to main after I got it tested in CI
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1032937554
Just copying the nice image again to drag attention:
Pretty please:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1026290847
That one will help with errors for Airflow 2.1.0 compatibility for providers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1025181075
Right - this is the final version:
I just pushed it error-free so that we can merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1024125403
cc: @pateash @kazanzhy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1024989111
Much better errror output:
<img width="1306" alt="Screenshot 2022-01-29 at 22 23 01" src="https://user-images.githubusercontent.com/595491/151677995-3cad0082-28dd-44fc-bec2-859b75101e0a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1032936503
Hello :) :) :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1030871457
Anyone please :) . This will be a life-saver for those who will be adding features for providers. @turbaszek I think you even requested it once and I thought it was fixed - but this one should be way better (see #13924)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21182:
URL: https://github.com/apache/airflow/pull/21182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1026741576
This one will be nice for users who struggle with Airflow 2.1 compatibility for providers :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1026742449
cc: @pateash WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk removed a comment on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk removed a comment on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1026290847
That one will help with errors for Airflow 2.1.0 compatibility for providers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash commented on pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
pateash commented on pull request #21182:
URL: https://github.com/apache/airflow/pull/21182#issuecomment-1026755581
> cc: @pateash WDYT ?
This looks great. Cheers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21182: Display better error message when importing providers has errors
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21182:
URL: https://github.com/apache/airflow/pull/21182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org