[GitHub] [spark] wangyum commented on a change in pull request #32097: [WIP][SPARK-34884][SQL] Improve DPP evaluation

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #32097:
URL: https://github.com/apache/spark/pull/32097#discussion_r609779600



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PlanDynamicPruningFilters.scala
##########
@@ -75,15 +75,15 @@ case class PlanDynamicPruningFilters(sparkSession: SparkSession)
           val broadcastValues =
             SubqueryBroadcastExec(name, broadcastKeyIndex, buildKeys, exchange)
           DynamicPruningExpression(InSubqueryExec(value, broadcastValues, exprId))
-        } else if (onlyInBroadcast) {
-          // it is not worthwhile to execute the query, so we fall-back to a true literal
-          DynamicPruningExpression(Literal.TrueLiteral)
-        } else {
+        } else if (canBroadcastBySize(buildPlan, conf)) {

Review comment:
       cc @cloud-fan 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org