You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "StefanFranzWeiser (via GitHub)" <gi...@apache.org> on 2025/02/06 16:17:46 UTC
[PR] Upgrade Http Bridge Dependencies [felix-dev]
StefanFranzWeiser opened a new pull request, #378:
URL: https://github.com/apache/felix-dev/pull/378
The bridge imports on jakarta.servlet.descriptor avoids to deploy the bridge on Tomcat 11 correctly because Tomcat 11 provides v6.1. All other jakarta dependencies are open to exlude v7, see:
`
Import-Package: jakarta.servlet;version="[5.0,7)",jakarta.servlet.http
;version="[5.0,7)",org.osgi.service.useradmin;resolution:=optional;ve
rsion="[1.1,2)",sun.misc;resolution:=optional,sun.nio.ch;resolution:=
optional,jakarta.servlet.descriptor;version="[5.0,6)",java.io,java.la
ng,java.lang.invoke,java.lang.ref,java.lang.reflect,java.math,java.ne
t,java.nio,java.nio.channels,java.nio.charset,java.nio.file,java.nio.
`
Upgrading the bridge dependencies fixes the problem. Root cause is the reference on the old wrapper version 1.0.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "StefanFranzWeiser (via GitHub)" <gi...@apache.org>.
StefanFranzWeiser commented on code in PR #378:
URL: https://github.com/apache/felix-dev/pull/378#discussion_r1945998189
##########
http/bridge/pom.xml:
##########
@@ -179,17 +179,17 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.15.0</version>
+ <version>2.18.0</version>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.http.base</artifactId>
- <version>5.1.8</version>
+ <version>5.1.10</version>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.http.wrappers</artifactId>
- <version>1.0.2</version>
+ <version>1.0.6</version>
Review Comment:
Using 1.1.8 would cause breaking changes from API perspective (build failure). Therefore, I sticked on 1.0.6, the latest compatible one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "StefanFranzWeiser (via GitHub)" <gi...@apache.org>.
StefanFranzWeiser commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2643220252
Just identified that http.proxy is also limited to jakarta servlet 5. When upgrading to 6 only the ServletContextWrapper does not compile which is adapted fast.
Summing up, looks like felix http does not support jakarta servlet 6 totally at the moment. 😞
Therefore, will adapt it for my purpose and base on my fork instead (and keep waiting for new release 😄).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "StefanFranzWeiser (via GitHub)" <gi...@apache.org>.
StefanFranzWeiser commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2646967897
The updated proxy and bridge works from dependency management. By the way, I saw that the ProxyListener was removed (also mentioned in Tutorials). Was this intended? I changed it to ProxyServletContextListener, hoping everything works as intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "StefanFranzWeiser (via GitHub)" <gi...@apache.org>.
StefanFranzWeiser commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2642026958
> Instead of moving the dependency to 6.1.0, wouldn't it suffice to add the version range in the import package?
>
> ```
> jakarta.servlet.descriptor;version="[5.0,7)"
> ```
The version range is not defined by the bridge, instead inherited from the wrappers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2646970153
Thanks for the feedback. Yes, ProxyListener has been replaced by ProxyServletContextListener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2642041679
While it might work, still wrappers 1.0.x is for servlet 5 and 1.1.x is for servlet 6.
If we just support servlet 6 with the bridge then we need of course to change the version range for all servlet packages to be [6,7),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "StefanFranzWeiser (via GitHub)" <gi...@apache.org>.
StefanFranzWeiser commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2648013268
Solved with new v6.0.0, thx to @cziegeler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "paulrutter (via GitHub)" <gi...@apache.org>.
paulrutter commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2640745882
Instead of moving the dependency to 6.1.0, wouldn't it suffice to add the version range in the import package?
```
jakarta.servlet.descriptor;version="[5.0,7)"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "StefanFranzWeiser (via GitHub)" <gi...@apache.org>.
StefanFranzWeiser commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2642031576
> The intention of the bridge is to run with both servlet 5 and servlet 6. However, servlet 5 needs wrappers 1.0.x and servlet 6 needs wrapper 1.1.x . We can either create a second module (one for servlet 5 and one for servlet 6), or from now on we require at least servlet 6. I think we should start with the latter and when users later request a bridge for servlet 5 create it on demand.
On my side wrappers 1.0.6 is enough and repairs the version range for my purpose. At the moment, the bridge cannot be used for servlet v6 because jakarta.servlet.descriptor limits it to v5, while jakarta.servlet and jakarta.servlet.http are open to v5 and v6.
Tomcat 9 is still on javax.
Tomcat 10 uses jakarta servlet 6.0.
Tomcat 11 uses jakarta servlet 6.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "paulrutter (via GitHub)" <gi...@apache.org>.
paulrutter commented on code in PR #378:
URL: https://github.com/apache/felix-dev/pull/378#discussion_r1945254536
##########
http/bridge/pom.xml:
##########
@@ -179,17 +179,17 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.15.0</version>
+ <version>2.18.0</version>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.http.base</artifactId>
- <version>5.1.8</version>
+ <version>5.1.10</version>
</dependency>
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.http.wrappers</artifactId>
- <version>1.0.2</version>
+ <version>1.0.6</version>
Review Comment:
1.1.8 is latest for wrappers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "StefanFranzWeiser (via GitHub)" <gi...@apache.org>.
StefanFranzWeiser closed pull request #378: Upgrade Http Bridge Dependencies
URL: https://github.com/apache/felix-dev/pull/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2642486307
As long as you don't use some of the new methods from servlet 6, the bridge will work with servlet 5. As soon as you try to use those methods it will fail *if* the wrappers are needed during a request. Which means if there is some code relying on javax.servlet. The combination of code using javax.servlet and at the same time using servlet 6 methods is very unlikely to happen, therefore you probably do not notice any problems. But still its possible to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2646219694
@StefanFranzWeiser I updated http proxy and bridge to Jakarta Servlet 6 in https://github.com/apache/felix-dev/commit/9899d3e8ec54bd4f4f722bc11001586d85b8cc25 . It would be great if you could give it a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "StefanFranzWeiser (via GitHub)" <gi...@apache.org>.
StefanFranzWeiser commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2642054055
If wrappers 1.0.x are for servlet 5 and 1.1.x is for servlet 6, does the bridge then only support servlet 5 at the moment, not 6? This would not be cool :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Http Bridge Dependencies [felix-dev]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #378:
URL: https://github.com/apache/felix-dev/pull/378#issuecomment-2642011862
The intention of the bridge is to run with both servlet 5 and servlet 6. However, servlet 5 needs wrappers 1.0.x and servlet 6 needs wrapper 1.1.x .
We can either create a second module (one for servlet 5 and one for servlet 6), or from now on we require at least servlet 6.
I think we should start with the latter and when users later request a bridge for servlet 5 create it on demand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org