You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/04 08:43:47 UTC
Review Request 35049: DRILL-2089: Part 4--Update package names of
moved classes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35049/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Updated package names of moved classes:
- In own package declaration.
- In references in imports.
- In references in string literals. [DriverImpl]
- In ProGuard configuration for JDBC-all Jar file.
- Also added DrillConnection and DrillStatement to parallel recent addition of DrillResultSet.
Diffs
-----
exec/jdbc-all/pom.xml f320ef7
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 55453e8
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/AvaticaDrillSqlAccessor.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/BasicList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillAccessorList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc40Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPrepareResult.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementRegistry.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/GlobalServiceSetReference.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillColumnMetaDataListTest.java a6f2325
Diff: https://reviews.apache.org/r/35049/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay
Re: Review Request 35049: DRILL-2089: Part 4--Update package names of
moved classes.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35049/#review87289
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On June 4, 2015, 6:43 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35049/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 6:43 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2089
> https://issues.apache.org/jira/browse/DRILL-2089
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Updated package names of moved classes:
> - In own package declaration.
> - In references in imports.
> - In references in string literals. [DriverImpl]
> - In ProGuard configuration for JDBC-all Jar file.
> - Also added DrillConnection and DrillStatement to parallel recent addition of DrillResultSet.
>
>
> Diffs
> -----
>
> exec/jdbc-all/pom.xml f320ef7
> exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 55453e8
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/AvaticaDrillSqlAccessor.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/BasicList.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillAccessorList.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc40Factory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPrepareResult.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementRegistry.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/GlobalServiceSetReference.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillColumnMetaDataListTest.java a6f2325
>
> Diff: https://reviews.apache.org/r/35049/diff/
>
>
> Testing
> -------
>
> Ran existing tests. (With parts 1 through 7 together.)
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35049: DRILL-2089: Part 4--Update package names of
moved classes.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35049/
-----------------------------------------------------------
(Updated June 16, 2015, 12:17 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Re-uploaded patches to try to resolve Review Board's empty-files problem.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Updated package names of moved classes:
- In own package declaration.
- In references in imports.
- In references in string literals. [DriverImpl]
- In ProGuard configuration for JDBC-all Jar file.
- Also added DrillConnection and DrillStatement to parallel recent addition of DrillResultSet.
Diffs (updated)
-----
exec/jdbc-all/pom.xml f320ef7
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 55453e8
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/AvaticaDrillSqlAccessor.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/BasicList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillAccessorList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillHandler.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc40Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPrepareResult.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillRemoteStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementRegistry.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DriverImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/GlobalServiceSetReference.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/MetaImpl.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillColumnMetaDataListTest.java a6f2325
Diff: https://reviews.apache.org/r/35049/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay